Remove legacy quote-form.js script includes from HTML pages#167
Open
Remove legacy quote-form.js script includes from HTML pages#167
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/assets/js/quote-form.jswas still being included site-wide, creating unnecessary requests and potential script conflicts.Description
<script src="/assets/js/quote-form.js" defer></script>include from 70 HTML pages (footer script blocks acrossabout/,care-program/,commercial/,faq/,get-a-quote/,paver-sealing/,service-areas/,warranty/, etc.).quote-form.jsfrom/get-a-quote/index.htmlso the page only contains the active Jobber embed script.assets/js/quote-form.jsfile untouched in the repo and flagged it as unused so it can be removed in a follow-up cleanup commit.Testing
rg -n "quote-form\.js" --glob '*.html'and confirmed includes were found across many pages. (succeeded)rg -n "quote-form\.js" || true. (succeeded — no matches)/get-a-quote/still contains the Jobber embed script and representative pages no longer include the legacy script; the embed attempted to load but remote CORS prevented full iframe load (expected for local testing). (succeeded — embed tag present, legacy include absent)assets/js/quote-form.jsstill exists on disk but is no longer referenced by any HTML files and can be safely deleted in a later follow-up. (succeeded)Codex Task