Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
RECEIPT_SIGNING_PRIVATE_KEY_PEM_B64,RECEIPT_SIGNING_PUBLIC_KEY_B64, andRECEIPT_SIGNER_IDwhile continuing to accept legacyCL_aliases, implemented inserver.mjsviaenvAnySource/runtimeConfignormalization.RECEIPT_SIGNING_PUBLIC_KEY_B64) or legacy PEM and extract raw32, and derive a deterministickidfromsha256(pubkey_raw32)(base64url slice).signReceiptEd25519Sha256from@commandlayer/runtime-core, and the server fails fast at boot with a clear error when signer config is invalid unlessDEV_AUTO_KEYS=1(which generates ephemeral in-memory keys)./verifyto use env pubkey by default and?ens=1to fetch ENS TXT (cl.sig.pub,cl.sig.canonical, optionalcl.sig.kid) with optional?strict_kid=1enforcement, and normalize response to exposeok,reason?,signer_id,kid,hash_sha256, andverified_with.signer_ok,signer_id,kid,signer_source, andpublic_key_fingerprint, add test-only ENS mocking viaENS_MOCK_TXT_JSON, and update docs and.env.exampleto match the Railway canonical vars and ENS TXT format.server.mjs,runtime/tests/runtime-signing.test.mjs(new),.env.example,README.md, anddocs/CONFIGURATION.md.Testing
npm run test:unitand all tests passed (16 tests across existing suites and new signing tests).npm testwhich executed unit tests and the smoke test and succeeded end-to-end (including run-time signing and verify roundtrip).node --check server.mjsand executed an ad-hoc sample script to start the server and mint a sample receipt which showed expected/healthandmetadata.prooffields, confirming thekidandsignature_b64were present and valid.Codex Task