FEC-434: feat(detail-page): create DetailPage compound component#1167
Open
FEC-434: feat(detail-page): create DetailPage compound component#1167
Conversation
🦋 Changeset detectedLatest commit: 56d57bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ByronDWall
reviewed
Feb 26, 2026
Contributor
ByronDWall
left a comment
ByronDWall
left a comment
There was a problem hiding this comment.
Overall this is looking really good. It has caused me to make some changes in the MainPage PR as well. I definitely think it needs an Actions section in the header, and it's worth considering using grid instead of flex for the recipe.
packages/nimbus/src/components/detail-page/detail-page.recipe.ts
Outdated
Show resolved
Hide resolved
packages/nimbus/src/components/detail-page/components/detail-page.header.tsx
Show resolved
Hide resolved
packages/nimbus/src/components/detail-page/components/detail-page.content.tsx
Outdated
Show resolved
Hide resolved
misama-ct
force-pushed
the
CRAFT-2166-create-detail-page-component
branch
from
ce0b3cb to
9f7695f
Compare
misama-ct
requested review from
a team,
jaikamat and
stephsprinkle
and removed request for
a team
…ns from documentation
…ges to Patterns/Pages - Align DetailPage recipe to MainPage grid blueprint (gridTemplateRows, header margin/padding, footer inset, headerActions gridRow span) - Add minHeight: 0 to content slot to prevent 1fr overflow with tall content - Add StickyTableHeader story with Box height constraint to demonstrate DataTable sticky header - Fix WithCustomHeaderContent Toolbar placement with gridColumn="1 / -1" - Move DetailPage, MainPage, PageContent stories to Patterns/Pages category
misama-ct
force-pushed
the
CRAFT-2166-create-detail-page-component
branch
from
ae2bfd6 to
a43a4b9
Compare
…o TabNav
Replace Tabs (content-switching widget with role="tablist") with TabNav
(nav landmark with aria-current="page" links) for page-level navigation
in DetailPage and MainPage stories, docs, and specs.
Add DetailPage.TabNav and MainPage.TabNav layout container sub-components
(recipe slot) that position themselves in the header grid's last row at
full width. Consumers wrap TabNav.Root inside, or use as={TabNav.Root}
for a flatter DOM.
…mponents Remove grid gaps from DetailPage header, fix MainPage header alignItems typo, align content and footer spacing to use identical values in both page components.
…rders reach page edges
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
DetailPage SB
DetailPage Docs
Summary
Adds the
DetailPagecompound component — a page skeleton with back navigation, header, scrollable content area, and optional footer. Replaces the structural layout of MC'sTabularDetailPage,InfoDetailPage,CustomFormDetailPage, andFormDetailPage.Component parts
DetailPage.RootDetailPage.HeaderDetailPage.BackLinkuseLinkwith i18n default label ("Go back")DetailPage.Title<h1>)DetailPage.SubtitleDetailPage.HeaderActionsDetailPage.Content<main>content areaDetailPage.FooterKey decisions (deviations from CRAFT-2166)
PageContentinsideDetailPage.Contentwhen they need width constraints, rather than a pass-throughvariantpropDetailPage.Content— maintains a single<main>landmark and proper scroll propagation (not as siblings between header and footer)HeaderActionspositioned via grid named areasAlso includes
flex: 1+minHeight: 0on Tabs root for proper scrolling in flex parents (separate OpenSpec proposal atopenspec/changes/update-tabs-flex-layout/).dev.mdx,.mdxindex page,.docs.spec.tsxconsumer testsTest plan
.docs.spec.tsx)Related