feat: add Figma Code Connect mappings for all components#1251
Draft
ByronDWall wants to merge 5 commits intomainfrom
Draft
feat: add Figma Code Connect mappings for all components#1251ByronDWall wants to merge 5 commits intomainfrom
ByronDWall wants to merge 5 commits intomainfrom
Conversation
Add .figma.tsx files for 44 components mapping Figma design properties to code props. Includes simplified data collection script and generation skill for maintaining mappings. Closes CRAFT-2151 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
 Failed |
SAST | 2 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
🛡️ The following SAST misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
|
User-controlled URLs May Allow Server-Side Request Forgery (SSRF) Attacks | ...ollect-figma-data.ts | View in code |
|
User-controlled URLs May Allow Server-Side Request Forgery (SSRF) Attacks | ...ollect-figma-data.ts | View in code |
Remove #NNN:NN suffixes from all figma property names (internal Figma IDs not recognized by Code Connect). Add figma.config.json to configure parser and include globs. All 50 mappings now pass dry-run validation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…and structural elements - Add figma.children to all compound components (Accordion, Card, ComboBox, Dialog, DraggableList, FormField, RadioInput, Steps, TagGroup, Tooltip) - FormField: add Label, InfoBox (boolean toggle), Input (instance swap), and variant-based Error/Description selection - Toast: fix import to resolve directly from outlet file - Update skill with new patterns: compound children, boolean visibility toggles, variant-based sub-component selection, static structural elements Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…d pnpx guideline Moves code-connect generation into a Claude skill, updates all .figma.tsx files with improved examples, adds .env.template, and documents pnpx/pnpm exec usage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix phantom props (isClearable on Alert, highPrecisionIndicator on MoneyInput, trailingElement on MultilineTextInput, variant on ToastOutlet, isClearable/ calendarButton on DatePicker), add missing required props (firstName/lastName on Avatar, count on Steps), and wire up captured-but-unused leadingElement/ trailingElement props in input component examples. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.figma.tsxCode Connect files for 44 components, mapping Figma design properties to code props for Dev Modescripts/generate-code-connect.tsto pure data collection (outputsscripts/code-connect-data.json)review-code-connectskill for intelligent.figma.tsxgeneration from collected dataCloses CRAFT-2151
Test plan
npx figma connect publishto verify all mappings are validpnpm typecheck🤖 Generated with Claude Code