Skip to content

FEC-365: Extend MoneyInput with Non-Iso Currencies#1254

Merged
misama-ct merged 3 commits intomainfrom
FEC-365-extends-money-inputs-non-iso-nimbus
Mar 18, 2026
Merged

FEC-365: Extend MoneyInput with Non-Iso Currencies#1254
misama-ct merged 3 commits intomainfrom
FEC-365-extends-money-inputs-non-iso-nimbus

Conversation

@nima-ct
Copy link
Collaborator

@nima-ct nima-ct commented Mar 13, 2026

Summary
This PR adds support for non-ISO currency variants (HUF0, KZT0,...) in the currency lookup table from MoneyInput

This change is needed so that non-ISO currencies are correctly recognized and handled in the Merchant Center money inputs.

https://commercetools.atlassian.net/browse/FEC-354

@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nimbus-documentation Ready Ready Preview, Comment Mar 17, 2026 10:07am
nimbus-storybook Ready Ready Preview, Comment Mar 17, 2026 10:07am

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2026

🦋 Changeset detected

Latest commit: 70db0b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@commercetools/nimbus Patch
@commercetools/nimbus-tokens Patch
@commercetools/nimbus-icons Patch
@commercetools/nimbus-design-token-ts-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@misama-ct misama-ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although no mechanics changed, the introduction of non-iso currencies warrants a changeset and an openspec proposal. For the changeset we have a pnpm command, for the proposal we have a claude command (you can retroactively create a proposal).

Comment on lines +239 to +244
CZK0: { fractionDigits: 0 },
HUF0: { fractionDigits: 0 },
ILS0: { fractionDigits: 0 },
KZT0: { fractionDigits: 0 },
TRY0: { fractionDigits: 0 },
TWD0: { fractionDigits: 0 },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Not sure if important, but since I read through the linked tickets and docs: here it is mentioned its only 5 new currencies, CZK0 is missing there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for pointing this out. The new one has been shared later.
This is the current list of new currencies:
https://fs-44-custom-currencies.preview-docs.commercetools.com/api/types#ctp:api:type:NonStandardCurrency

Copy link
Collaborator

@misama-ct misama-ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@misama-ct misama-ct merged commit 8e6f117 into main Mar 18, 2026
9 checks passed
@misama-ct misama-ct deleted the FEC-365-extends-money-inputs-non-iso-nimbus branch March 18, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants