Skip to content

CRAFT [FEC] -2082 - Update to eslint9#3224

Open
valoriecarli wants to merge 2 commits intomainfrom
CRAFT-2082-eslint9
Open

CRAFT [FEC] -2082 - Update to eslint9#3224
valoriecarli wants to merge 2 commits intomainfrom
CRAFT-2082-eslint9

Conversation

@valoriecarli
Copy link
Contributor

@valoriecarli valoriecarli commented Mar 13, 2026

Migrate to ESLint 9 flat config

Migrates the root workspace from ESLint 8 legacy config to ESLint 9 flat config, following the migration guide shipped with @commercetools-frontend/eslint-config-mc-app@27.0.0.

Changes:

  • Replaced .eslintrc.js + eslintignore with eslint.config.js (ignore patterns inlined, overrides converted to flat config objects)
  • Bumped eslint 8.x → ^9.0.0 and eslint-config-mc-app to 27.0.0
  • Removed cliOptions.rules from jest-runner-eslint.config.js - not supported in flat config mode; both rules were already covered by the base config
  • Added globals.jest for **/*.visualspec.js and **/*.bundlespec.js - the base config only injects Jest globals for
    *.{spec,test}.*
  • Removed stale @typescript-eslint/no-empty-function eslint-disable comments in test/setup-tests.js - @typescript-eslint is not registered for .js files in flat config, making those comments invalid

@valoriecarli valoriecarli self-assigned this Mar 13, 2026
@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ui-kit Ready Ready Preview, Comment Mar 13, 2026 3:38pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2026

⚠️ No Changeset found

Latest commit: 593f9d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@valoriecarli valoriecarli marked this pull request as ready for review March 13, 2026 15:45
@valoriecarli valoriecarli requested a review from a team as a code owner March 13, 2026 15:45
@valoriecarli valoriecarli changed the title Craft 2082 eslint9 CRAFT [FEC] -2082 - Update to eslint9 Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant