Skip to content

test(money-input): update to accept new thousands separator for de-CH… #3225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ByronDWall merged 2 commits into from
Mar 17, 2026
Merged

test(money-input): update to accept new thousands separator for de-CH… #3225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ee4bb3
test(money-input): update to accept new thousands separator for de-CH…
valoriecarli Mar 16, 2026
1679d9c
test(money-input): lets try it this way
valoriecarli Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/components/inputs/money-input/src/money-input.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,12 @@ describe('MoneyInput.parseMoneyValue', () => {
},
'de-CH'
)
).toEqual({ amount: '1’234.567', currencyCode: 'EUR' });
// The Unicode locale data (CLDR) changed the de-CH thousands separator from a right single quote (U+2019)
// to a plain apostrophe (U+0027) in Node 24.13.1+. Accept both to stay compatible across Node versions.
).toEqual({
amount: expect.stringMatching(/^1[\u2019\u0027]234\.567$/),
currencyCode: 'EUR',
});
Copy link
Contributor Author

@valoriecarli valoriecarli Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed feelings between this solution, or normalizing the output in formatAmount by replacing U+0027 → U+2019 after toLocaleString runs (thereby enforcing U+2019 as the canonical de-CH thousands separator
regardless of ICU version)

});
});

Expand Down
Loading