Fixes Issue #6534: Missing Wikipedia Link in Nearby #6562
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Sitelinks from local data Before this change, when information about a Place was retrieved from the local Place repository, the Sitelink object was not set into the new Place object. This would cause the Sitelink icons to be missing from the user interface for some Places. This change now sets the Sitelinks object to the locally retrieved Place's Sitelinks. These sitelinks now appear in the user interface if they are stored locally.
Collaborator
Author
|
Also, when I was fixing this issue I noticed that the method |
Member
|
How about a different PR, unless not refactoring makes your work much more difficult? Thanks a lot! 🙂 |
|
✅ Generated APK variants! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6534
What changes did you make and why?
The only change was a single line of code added: When data is being retrieved from the local
Placerepository, thePlaceobject which is used by the Nearby activity is now correctly assigned the local Place'sSitelinkobject.Sitelinks will now appear in the user interface.
Tests performed (required)
This bug seems to only appear when retrieving
Placedata from the local Place repository (not from Wikidata queries). To test, use Places which are known to be stored locally.On main, the Sitelinks will not appear in the user interface. On this PR, the Sitelinks will appear (see screenshot below).
Tested ProdDebug on Android Studio emulator with API level 36.
Screenshots (for UI changes only)