Skip to content

#1076 - Egen komponent for Card i designsystemet #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
rebalv wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

#1076 - Egen komponent for Card i designsystemet #54

rebalv wants to merge 17 commits into from

Conversation

@rebalv
Copy link
Contributor

@rebalv rebalv commented Oct 22, 2025 •
edited
Loading

✨ Endringer i denne PRen

  • I denne PRen har jeg laget en veldig enkel komponent for Card med image, title, href og slots for subtitle og other.
  • Det er tatt utgagnspunkt i stylingen fra EventCard i chubben-arrangementer-frontend
  • Inkluderer nye css-filer for de ulike typografiklassene

@rebalv rebalv marked this pull request as draft October 22, 2025 09:35
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@rebalv rebalv requested a review from matpbk October 22, 2025 11:34
matpbk
matpbk reviewed Oct 22, 2025
View reviewed changes
matpbk
matpbk reviewed Oct 23, 2025
View reviewed changes
matpbk
matpbk reviewed Oct 23, 2025
View reviewed changes
matpbk
matpbk reviewed Oct 23, 2025
View reviewed changes
matpbk
matpbk reviewed Oct 23, 2025
View reviewed changes
matpbk
matpbk reviewed Oct 23, 2025
View reviewed changes
matpbk
matpbk reviewed Oct 23, 2025
View reviewed changes
matpbk
matpbk reviewed Oct 23, 2025
View reviewed changes
@matpbk
Copy link
Contributor

matpbk commented Oct 23, 2025

Vi bruker markdown for dokumentasjon, du kan se i de andre komponentene at vi har en "Overview.mdx" fil.

matpbk
matpbk reviewed Oct 23, 2025
View reviewed changes
matpbk
matpbk reviewed Oct 23, 2025
View reviewed changes
matpbk
matpbk reviewed Oct 23, 2025
View reviewed changes
matpbk
matpbk reviewed Oct 23, 2025
View reviewed changes
matpbk
matpbk reviewed Oct 23, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

john-melin
john-melin reviewed Oct 23, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

john-melin
john-melin reviewed Oct 23, 2025
View reviewed changes
john-melin
john-melin reviewed Oct 23, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@rebalv rebalv requested a review from eTallang October 30, 2025 08:50
@github-actions
Copy link

github-actions bot commented Oct 30, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

john-melin
john-melin reviewed Nov 8, 2025
View reviewed changes
packages/lib/components/card/card.ts Outdated

return this.href
? html`
<a href="${this.href}" class="card clickable">
Copy link
Collaborator

@john-melin john-melin Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vi burde egentlig unngå bake in <a tags i komponentene våre fordi mange rammeverk har sine egne Lenke komponenter for å fungere som en SPA. En vanlig <a tag vil gi en full refreshe og navigasjon på siden. Det blir også problemer med skjermleser hvis card inneholder knapper i tillegg.

Så tenker at om man heller lar konsumenten av card f.eks wrappe den i en Lenke komponent selv hvis det skal brukes som lenke så vil det alltid funke :)

@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-desert-023cb6603-54.westeurope.5.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@john-melin john-melin john-melin left review comments

@matpbk matpbk matpbk left review comments

@eTallang eTallang Awaiting requested review from eTallang

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rebalv @matpbk @john-melin