-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[feature] Improve package signing plugin integration: new commands, tools and output format #18785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
conan/internal/rest/pkg_sign.py
Outdated
| file_path = os.path.join(self._artifacts_folder, fname) | ||
| if os.path.isfile(file_path): | ||
| sha256 = sha256sum(file_path) | ||
| checksums[fname] = sha256 | ||
| sorted_checksums = dict(sorted(checksums.items())) | ||
| content = copy.deepcopy(self.SIGN_SUMMARY_CONTENT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is doing a checksum of all artifacts in the package?
What exactly for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agreed that this should be the way the plugin should work. Get the cheksums of all the contetns of the package, create a summary file with filenames and checkesums and use that file to sign the package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But maybe, this is the kind of thing that shouldn't belong then to user space? This is something that Conan should kind of enforce in the plugin? Or do we still envision other possible signing approaches that do not sign this file?
|
@danimtb what about something like this for the output? I think it may be more readable? |
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
…nto feature/improve_pkg-sign
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
…nto feature/improve_pkg-sign
|
Superseded by #19345 |
Changelog: Feature: Improve package signing plugin integration.
Changelog: Feature: Add
conan cache signandconan cache verifycommands for package signing.Changelog Feature: Standardize package summary format with files, checksums, signing method and signing provider.
Docs: missing