Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
|
Merging without review, as the constituent parts have already been reviewed. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds V3 announcement banner support to CODAP v2 by configuring the Cloud File Manager (CFM) to fetch and display banner content from a remote JSON file. The banner feature enables announcements to users about the upcoming CODAP v3 release. Additionally, the PR fixes a Node.js 17+ compatibility issue in the CFM build script and adds documentation for managing S3 assets.
Changes:
- Configures CFM banner URL pointing to S3-hosted JSON file for V3 announcement
- Adds
NODE_OPTIONS=--openssl-legacy-providertobuild:cfmscript for Node 17+ compatibility - Includes CFM rebuild artifacts (version 1.9.4) with new banner CSS and UI improvements
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Adds NODE_OPTIONS flag to build:cfm script for Node 17+ compatibility |
| cfm-version.txt | Updates CFM version to 1.9.4 and commit hash after rebuild |
| apps/dg/resources/cloud-file-manager/css/app.css | Includes new CFM banner styles and unrelated UI improvements from CFM rebuild |
| apps/dg/main.js | Configures banner URL in CFM initialization options |
| .claude/skills/codap-resources/SKILL.md | Adds new skill documentation for managing S3 bucket assets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codap-resources.concord.org/notifications/announcing-v3-banner.jsonbuild:cfmscript to includeNODE_OPTIONS=--openssl-legacy-providerfor Node 17+ compatibilitycodap-resourcesClaude Code skill for managing S3 bucket assetsTest plan
🤖 Generated with Claude Code