CODAP-1112: Add ownership-aware string handling to V2 build skill#2390
Merged
CODAP-1112: Add ownership-aware string handling to V2 build skill#2390
Conversation
Update Phase 2 Step 4 to categorize string differences by ownership (DG.* vs V3.*), accept V3 changes from POEditor locally, and filter push to only send DG-owned keys. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the codap-v2-build Claude skill documentation to support ownership-aware handling of English strings when CODAP V2 and V3 share a single POEditor project, so V2 builds can avoid modifying V3-owned strings while still staying in sync.
Changes:
- Documented V2 vs V3 string ownership expectations for the shared POEditor project.
- Added a diff-categorization step (DG.* vs V3.*) and instructions to accept V3 changes locally.
- Updated push guidance to filter and push only DG.* keys to POEditor.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
In response to Copilot code review on PR #2390: - Clarify that only DG.* and V3.* prefixes exist in the project - Handle new V3 keys from POEditor (not just updates to existing keys) - Fix "V3 strings" wording to "non-DG strings" for precision Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The language count varies between V2 and V3 scripts and may change over time, so avoid specifying a number that can go stale. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Brings V2 in sync with V3 — both now pull all 18 POEditor languages with ≥50% translation coverage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
npm ci is the correct command for reproducible builds — it installs from the lockfile exactly and never modifies package-lock.json. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codap-v2-buildskill with ownership-aware string handling for the V2/V3 shared POEditor projectJira
CODAP-1112
Related
CODAP-1112-sync-v3-strings-poeditorhas the V3-side changesTest plan
🤖 Generated with Claude Code