CODAP-1123: make V2 build read-only for POEditor string management#2406
Merged
CODAP-1123: make V2 build read-only for POEditor string management#2406
Conversation
V3 build now owns all string pushes to POEditor (both DG.* and V3.* keys). V2 build only pulls translations, never pushes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Arabic translation was never completed, so exclude it from releases. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CODAP v2 translation workflow to align with CODAP-1123 by making the v2 build guidance “pull-only” (no POEditor pushes) and by excluding Arabic from the v2 translation pull set.
Changes:
- Remove Arabic (
ar) from the V2strings-pull-project.shlanguage list. - Update the CODAP v2 build skill documentation to describe POEditor string management as read-only for V2 (V3 owns pushes).
- Simplify/renumber the translation-related steps in the v2 build skill to focus on pulling translations and propagating to plugins.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bin/strings-pull-project.sh |
Drops ar from the language pull list used for per-language POEditor downloads. |
.claude/skills/codap-v2-build/SKILL.md |
Updates build instructions to reflect “pull-only” translation management and removes prior push/ownership workflow details. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DG.*andV3.*)Part of CODAP-1123. Companion PR targets
mainfor V3 changes.Test plan
strings-pull-project.shLANGUAGES array🤖 Generated with Claude Code