Skip to content

CODAP-575: add aria-label to tool shelf and inspector panel buttons #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kswenson merged 3 commits into from
Feb 25, 2026
+13 −2
Merged

CODAP-575: add aria-label to tool shelf and inspector panel buttons #2433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab98c4a
CODAP-575: add aria-label to tool shelf and inspector panel buttons
kswenson Feb 25, 2026
b27cef2
CODAP-575: fix plugins button tooltip to use correct translation key
kswenson Feb 25, 2026
4f9786d
CODAP-575: remove redundant aria-labels from tool shelf buttons; refa…
kswenson Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion v3/src/components/inspector-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,15 @@ import { isWithinBounds, getPaletteTopPosition } from "../utilities/view-utils"

import "./inspector-panel.scss"

// Returns an aria-label for icon-only inspector buttons/menus.
// When a visible text label exists, returns undefined (the label provides the accessible name).
// When no label exists, returns the tooltip with parenthetical keyboard shortcuts stripped
// (e.g. "bold (⌘-b)" → "bold") so screen readers announce a clean name.
function ariaLabel(label?: string, tooltip?: string) {
if (label) return undefined
return tooltip?.replace(/\s*\(.*\)$/, "")
}

interface IProps {
component?: string
show?: boolean
Expand Down Expand Up @@ -49,6 +58,7 @@ export const InspectorButton = forwardRef(function InspectorButton({
const className = clsx("inspector-tool-button", { active: isActive, bottom, top })
return (
<Button
aria-label={ariaLabel(label, tooltip)}
className={className}
isDisabled={isDisabled}
data-testid={testId}
Expand Down Expand Up @@ -81,7 +91,8 @@ export const InspectorMenu = ({
const classes = clsx("inspector-tool-button", "inspector-tool-menu", { bottom, top })
return (
<Menu isLazy onOpen={onOpen}>
<MenuButton className={classes} title={tooltip} data-testid={testId} onClick={onButtonClick}>
<MenuButton aria-label={ariaLabel(label, tooltip)} className={classes} title={tooltip} data-testid={testId}
onClick={onButtonClick}>
{icon}
{label && <span className="inspector-button-label">{label}</span>}
</MenuButton>
Expand Down
2 changes: 1 addition & 1 deletion v3/src/components/tool-shelf/plugins-button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ export const PluginsButton = observer(function PluginsButton() {
<>
<MenuButton
className={className}
title={t("DG.ToolButtonData.optionMenu.toolTip")}
title={t("DG.ToolButtonData.pluginMenu.toolTip")}
data-testid="tool-shelf-button-plugins"
>
<PluginsIcon />
Expand Down