Skip to content

CODAP-572: Improve accessibility of custom select dropdown menus #2436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kswenson wants to merge 10 commits into
base: main
Choose a base branch
from
+709 −44

CODAP-572: address Copilot review feedback

9687fb4
Select commit
Loading
Failed to load commit list.
Open

CODAP-572: Improve accessibility of custom select dropdown menus #2436

CODAP-572: address Copilot review feedback
9687fb4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 27, 2026 in 0s

69.31% (-16.23%) compared to e18ca30

View this Pull Request on Codecov

69.31% (-16.23%) compared to e18ca30

Details

Codecov Report

❌ Patch coverage is 74.10714% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.31%. Comparing base (e18ca30) to head (9687fb4).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
v3/src/hooks/use-submenu-keyboard-nav.ts 48.00% 13 Missing ⚠️
v3/src/components/case-card/case-attr-view.tsx 12.50% 7 Missing ⚠️
.../axis/components/axis-or-legend-attribute-menu.tsx 86.95% 3 Missing ⚠️
...c/components/case-tile-common/attribute-header.tsx 80.00% 1 Missing ⚠️
...components/inspector-panel/hide-show-menu-list.tsx 50.00% 1 Missing ⚠️
...omponents/inspector-panel/save-image-menu-list.tsx 50.00% 1 Missing ⚠️
...nts/slider/inspector-panel/slider-scales-panel.tsx 50.00% 1 Missing ⚠️
...s/slider/inspector-panel/slider-settings-panel.tsx 50.00% 1 Missing ⚠️
v3/src/components/tool-shelf/plugins-button.tsx 93.33% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e18ca30) and HEAD (9687fb4). Click for more details.

HEAD has 15 uploads less than BASE
Flag BASE (e18ca30) HEAD (9687fb4)
cypress 16 1
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2436       +/-   ##
===========================================
- Coverage   85.53%   69.31%   -16.23%     
===========================================
  Files         758      760        +2     
  Lines       42172    42275      +103     
  Branches    10049    10467      +418     
===========================================
- Hits        36070    29301     -6769     
- Misses       6090    12949     +6859     
- Partials       12       25       +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov