Update WikimediaChangesProducer.java #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(wikimedia-producer): pin okhttp-eventsource to 2.5.0, correct headers() API, add UA **Root cause** - Project initially used okhttp-eventsource 4.x where `EventHandler` was removed; IDE auto-imported `java.beans.EventHandler`, causing unresolved symbols. - After downgrades, the code still called `header(name, value)` which does not exist in 2.x; 2.x expects a single OkHttp `Headers` via `.headers(Headers)`. - Wikimedia SSE returned HTTP 403 because the request lacked a meaningful `User-Agent`. **Fix** - Pin dependency to `com.launchdarkly:okhttp-eventsource:2.5.0`. - Use the 2.x package `com.launchdarkly.eventsource.*` (not `java.beans.*`, not the 3.x `...okhttp...` package). - Build `okhttp3.Headers` and pass with `.headers(headers)` on `EventSource.Builder`. - Add a proper `User-Agent` header to avoid 403. - Minor: set `.reconnectTime(Duration.ofSeconds(3))` and keep Kafka client at 3.7.0. **Testing** - `./gradlew clean run` streams events and forwards to Kafka topic `wikimedia.recentchange`. - `curl -i -H "User-Agent: user-wiki-stream/1.0 (user@example.com)" \ https://stream.wikimedia.org/v2/stream/recentchange` returns `200` and events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(wikimedia-producer): pin okhttp-eventsource to 2.5.0, correct headers() API, add UA
Root cause
EventHandlerwas removed; IDE auto-importedjava.beans.EventHandler, causing unresolved symbols.header(name, value)which does not exist in 2.x; 2.x expects a single OkHttpHeadersvia.headers(Headers).User-Agent.Fix
com.launchdarkly:okhttp-eventsource:2.5.0.com.launchdarkly.eventsource.*(notjava.beans.*, not the 3.x...okhttp...package).okhttp3.Headersand pass with.headers(headers)onEventSource.Builder.User-Agentheader to avoid 403..reconnectTime(Duration.ofSeconds(3))and keep Kafka client at 3.7.0.Testing
./gradlew clean runstreams events and forwards to Kafka topicwikimedia.recentchange.curl -i -H "User-Agent: user-wiki-stream/1.0 (user@example.com)" \ https://stream.wikimedia.org/v2/stream/recentchangereturns200and events.