- 
                Notifications
    You must be signed in to change notification settings 
- Fork 23
Configurable batch size #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            emasab
  wants to merge
  16
  commits into
  master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
dev_fix_configurable_batch_size_2
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            16 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      f4b68b1
              
                Configurable batch size
              
              
                emasab 09c6197
              
                Keep 1.5s of data in cache
              
              
                emasab df6c833
              
                Remove minimum 1024 cache size for faster
              
              
                emasab cf45a3c
              
                Changed property name to `js.consumer.max.batch.size`
              
              
                emasab 28edb19
              
                Use only 1.5 seconds cache size estimation aligned at batch size * co…
              
              
                emasab e341232
              
                Fix for at-least-once guarantee not ensured in case a seek happens on…
              
              
                emasab 82a4867
              
                Configurable cache size in milliseconds
              
              
                emasab 03369f4
              
                Add worker identifier to the payload for better debugging
              
              
                emasab 940bc20
              
                Fix for test flakyness
              
              
                emasab bd0537f
              
                Make `is cleared before rebalance` less flaky in case of increased ti…
              
              
                emasab dc21a54
              
                Reduce flakyness of 'times out if messages are pending'
              
              
                emasab 9ae3f59
              
                1.6.1-alpha.1
              
              
                emasab d30ea6d
              
                fixup CHANGELOG and spaces
              
              
                emasab 5a7b93d
              
                1.6.1
              
              
                emasab 06e6bcb
              
                FIXME about KIP-848 autocommit issue
              
              
                emasab 697a98f
              
                Updated PR in changelog entry
              
              
                emasab File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|  | @@ -303,9 +303,11 @@ producerRun().then(consumerRun).catch(console.error); | |||||||||||
| - The `heartbeat()` no longer needs to be called by the user in the `eachMessage/eachBatch` callback. | ||||||||||||
| Heartbeats are automatically managed by librdkafka. | ||||||||||||
| - The `partitionsConsumedConcurrently` is supported by both `eachMessage` and `eachBatch`. | ||||||||||||
| - An API compatible version of `eachBatch` is available, but the batch size calculation is not | ||||||||||||
| as per configured parameters, rather, a constant maximum size is configured internally. This is subject | ||||||||||||
| to change. | ||||||||||||
| - An API compatible version of `eachBatch` is available, maximum batch size | ||||||||||||
| can be configured through the `js.consumer.max.batch.size` configuration property | ||||||||||||
| and defaults to 32. `js.consumer.max.cache.size.per.worker.ms` allows to | ||||||||||||
| configure the cache size estimated based on consumption rate and defaults | ||||||||||||
| to 1.5 seconds. | ||||||||||||
| 
      Comment on lines
    
      +308
     to 
      +310
    
   There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 
        Suggested change
       
 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure about this comment exactly, but at the moment I feel as if the  | ||||||||||||
| The property `eachBatchAutoResolve` is supported. | ||||||||||||
| Within the `eachBatch` callback, use of `uncommittedOffsets` is unsupported, | ||||||||||||
| and within the returned batch, `offsetLag` and `offsetLagLow` are supported. | ||||||||||||
|  | ||||||||||||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be 1.7.0