defaultToGlobal available in SRClient#4148
Open
Gremi64 (gremi64) wants to merge 6 commits intoconfluentinc:masterfrom
Open
defaultToGlobal available in SRClient#4148Gremi64 (gremi64) wants to merge 6 commits intoconfluentinc:masterfrom
Gremi64 (gremi64) wants to merge 6 commits intoconfluentinc:masterfrom
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Member
|
/sem-approve |
Member
Robert Yokota (rayokota)
left a comment
Robert Yokota (rayokota)
left a comment
There was a problem hiding this comment.
Thanks Gremi64 (@gremi64) , left some comments
| } | ||
|
|
||
| @Override | ||
| public Config getConfig(String subject, boolean defaultToGlobal) throws IOException, RestClientException { |
There was a problem hiding this comment.
Line is too long, try adding a newline before String subject
| return getConfig(subject).getCompatibilityLevel(); | ||
| } | ||
|
|
||
| default String getCompatibility(String subject, boolean defaultToGlobal) throws IOException, RestClientException { |
Member
There was a problem hiding this comment.
Line is too long, try adding a newline before String subject
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| default Config getConfig(String subject, boolean defaultToGlobal) throws IOException, RestClientException { |
Member
There was a problem hiding this comment.
Line is too long, try adding a newline before String subject
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
You can now use the "defaultToGlobal" parameter from the "SchemaRegistryClient.getCompatibility".
I implemented it in the "CachedSchemaRegistryClient".
Checklist
Please answer the questions with Y, N or N/A if not applicable.
References
JIRA:
As asked in this Issue : #2053 (comment)
Test & Review
Open questions / Follow-ups
Should i implement it in the "MockSchemaRegistryClient" too ? I can't figure what it should do... as it is a mock...