API endpoint URL query string parameters#162
Open
mustdobetter wants to merge 1 commit intoconsole-helpers:masterfrom
Open
API endpoint URL query string parameters#162mustdobetter wants to merge 1 commit intoconsole-helpers:masterfrom
mustdobetter wants to merge 1 commit intoconsole-helpers:masterfrom
Conversation
…ameters when editing an issue. Useful when, for example, you wish to prevent users from being notified of the update i.e. ?notifyUsers=false
aik099
requested changes
Oct 17, 2017
Member
aik099
left a comment
aik099
left a comment
There was a problem hiding this comment.
Also beware of using mixed indentation (as you're doing now). This library uses TABs for indentation.
| * @param $params Array of URL parameters: [key => value] | ||
| * @return string | ||
| */ | ||
| protected function formulateQueryString($params) |
Member
There was a problem hiding this comment.
There is PHP built-in function, that does it: http://php.net/manual/en/function.http-build-query.php
| $is_file = false, | ||
| $debug = false | ||
| $debug = false, | ||
| $url_params = array() |
Member
There was a problem hiding this comment.
This method already has too many params, so adding another one makes it a nightmare. Any other implementations you can suggest?
My options are:
- having special key in
$dataarray that won't match any parameter of existing in JIRA API (not necessary implemented in this library) for passing query parameters - use
http_build_querydirectly oneditIssuemethod and not add any parameters here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for specification of API endpoint URL query string parameters when editing an issue. Useful when, for example, you wish to prevent users from being notified of the update i.e. ?notifyUsers=false.