Feature/jira transitionbyname

[marek-knappe]

No description provided.

[aik099]

Here 2 PRs are mixed into one:

• deleteIssue method
• transitionByStepName method

[marek-knappe]

I put it on top of my changes for jira-deleteIssue as i gave the other one to merge yesterday, if somebody really want to merge it i can prepare branch with only transitionbystepname function i would have few more updates probably soon, and would be hard to remember which functions are working with others.

[aik099]

This library seems to be most promising JIRA REST API client on PHP I've seen, but I'm not sure if it's maintained, because last commit was 1 year ago and there are lots of unmerged PRs.

Library creator however is still doing something on GitHub according to his feed.

[marek-knappe]

I'm using it for few days - so don't know - it is very basic one but very easy to add your own functions.
there is many jira api missing, but using the functions that u have here it's easy to build your own functions for jira API - probably the owner of the repo just make it for himself and just include functions he need - but it's good start - i send to the creator email about pull request - will see maybe there will be some updates

[aik099]

From architecture viewpoint there are some even more promising libraries, but they have 1 or 2 functions implemented, so I've chosen this library.

[jpastoor]

PR looks good to me. Splitting would be nice, also added some inline comments around spelling / indentation etc. Not sure if author is up for fixing these things else we could merge it anyways.

[aik099]

@jpastoor please add comments on PR's diff, rather then on commits in it because comments on commits are lost when squashing happens.

[aik099]

The #57 (comment) isn't addressed as it seems.

[aik099]

Please remove extra line, because methods should separated by 1 line, not 2.

[marek-knappe]

StepName isn't a jira term, but it's easy to use step name (the name of the button above issue) to navigate. It's just easier to reffer it as text than as ID - even if text could be changed and ID cannot. but it would be more understandable if you would do:
$jira->updatejira(...);
$jira->transitionByStepName('Approved');
$jira->updatejira(..);
$jira->transitionByStepName('Completed');

[marek-knappe]

If you find it better (less going back and forward) I'm happy for you or anyone to make it properly :)

[aik099]

Please rebase and solve conflicts.