Skip to content

Conversation

@mtrmac
Copy link
Contributor

@mtrmac mtrmac commented Aug 20, 2025

We will, temporarily, want to run from rawhide images that include the rust-podman-sequoia RPM, as well as Fedora 43 images.

We have only one skopeo_cidev though, and we don't want to build a rawhide variant; so, allow consuming it from rawhide.

See individual commit messages for details.

A prerequisite for Sequoia containers/image#2876 , see https://github.com/containers/image/pull/2876/checks?check_run_id=48518809749 .

@lsm5 PTAL.

mtrmac added 2 commits August 20, 2025 21:42
> fgrep: warning: fgrep is obsolescent; using grep -F

Should not change behavior.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
We will, temporarily, want to run from rawhide images
that include the rust-podman-sequoia RPM, as well as Fedora 43
images.

We have only one skopeo_cidev though, and we don't want to build
a rawhide variant; so, allow consuming it from rawhide.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@lsm5
Copy link
Member

lsm5 commented Aug 21, 2025

@mtrmac LGTM if we need this happening soon. @cevich PTAL.

BTW, with the testing-farm jobs already in place and assuming #2640 will get merged (hopefully soon), would we need to worry about having this? IIRC, one reason to still have this would be to run tests locally without polluting your environment, but maybe the same could be achieved by running a toolbox container (?)

@cevich
Copy link
Member

cevich commented Aug 21, 2025

Another use-case could be get_ci_vm.sh but I'm doubting that gets used here much. I can't tell, but was a temporary commit used to confirm this logic actually works with rawhide?

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtrmac please merge whenever convenient.

@lsm5
Copy link
Member

lsm5 commented Aug 21, 2025

Ignore f43 testing-farm job. Compose isn't ready yet AFAICT. The testing-farm people will hopefully have a process change in place for f44 so that issue shouldn't occur from the next release forward.

@mtrmac
Copy link
Contributor Author

mtrmac commented Aug 25, 2025

BTW, with the testing-farm jobs already in place and assuming #2640 will get merged (hopefully soon), would we need to worry about having this?

We will need CI coverage of the Sequoia build configuration, probably in situations consistent with how we build distribution RPMs.

IIRC, one reason to still have this would be to run tests locally without polluting your environment

I’m not positively aware of anyone doing this — I rely on GitHub-connected CI ~exclusively. So I don’t have a strong opinion on whether / how that should be possible.

@mtrmac
Copy link
Contributor Author

mtrmac commented Aug 25, 2025

I can't tell, but was a temporary commit used to confirm this logic actually works with rawhide?

c/image #2876 was building against these images ; I’m trying to split the Skopeo PR into the CI-prerequisite + new-feature parts , and I didn’t actually test that the split is correct — I failed in a previous iteration.

Hopefully this will get it right; if not, I’ll do a proper isolated test c/image PR.

@mtrmac mtrmac merged commit fdcd7c3 into containers:main Aug 25, 2025
24 of 26 checks passed
@mtrmac mtrmac deleted the accept-rawhide branch August 25, 2025 11:12
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants