Skip to content

chore: update go version in go.mod for modern langauge features#46

Merged
kgiusti merged 1 commit intocontainers:mainfrom
rmiki-dev:gomod-update
Feb 25, 2026
Merged

chore: update go version in go.mod for modern langauge features#46
kgiusti merged 1 commit intocontainers:mainfrom
rmiki-dev:gomod-update

Conversation

@rmiki-dev
Copy link
Collaborator

This PR updates the go version in go.mod to go 1.25, as well as the go-version in the GitHub Actions workflow file.

@gemini-code-assist
Copy link

Summary of Changes

Hello @rmiki-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the project's Go environment by upgrading the Go language version to 1.25. This update facilitates the use of newer language features and performance enhancements, and it also involves updating the project's dependency graph to ensure compatibility and leverage updated module versions.

Highlights

  • Go Version Upgrade: The Go language version in go.mod has been updated from 1.14 to 1.25, enabling access to modern language features and improvements.
  • Dependency Updates: New indirect dependencies have been added to go.mod, and the go.sum file has been updated to reflect these changes and other module checksums.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • go.mod
    • Updated the Go language version from 1.14 to 1.25.
    • Added several new indirect require entries for various dependencies.
  • go.sum
    • Added new checksums for github.com/davecgh/go-spew, github.com/konsorten/go-windows-terminal-sequences, github.com/pmezard/go-difflib, github.com/stretchr/testify, and gopkg.in/yaml.v2.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/ci.yml
Activity
  • No specific activity (comments, reviews, progress) was provided for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version from 1.14 to 1.25. This is a very large jump to a future, unreleased version of Go, which is a significant risk for project stability and contributor experience. I've added a comment to go.mod regarding this. Also, the PR description mentions updating a GitHub Actions workflow, but the file change is missing from this PR, which will likely cause CI failures.

@rmiki-dev rmiki-dev force-pushed the gomod-update branch 3 times, most recently from f12c56d to 0bf473f Compare February 24, 2026 16:39
Signed-off-by: Rosy-Glorious Miki <rmiki@redhat.com>
Copy link
Collaborator

@mmartinv mmartinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@djach7 djach7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit below but not a blocker.

Nit: Update commit message for spelling error and add mention of updating makefile and CI. Maybe something like chore: update go version, update makefile, update CI

Copy link
Collaborator

@kgiusti kgiusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built/installed/test on Fedora 43 - all good

@kgiusti kgiusti merged commit 345d290 into containers:main Feb 25, 2026
3 checks passed
@rmiki-dev rmiki-dev deleted the gomod-update branch February 26, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants