-
Notifications
You must be signed in to change notification settings - Fork 4
docs: Add docs and web publishing #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
- Coverage 53.65% 52.07% -1.58%
==========================================
Files 13 13
Lines 863 797 -66
Branches 116 116
==========================================
- Hits 463 415 -48
+ Misses 327 309 -18
Partials 73 73 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crandmck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as for ios, can we test/preview this before landing?
|
At some point, we will probably want to change this to build/publish docs only on a release, rather than on push to main/docs branches. But at this stage, it should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the content from this file get folded into the generated docs? I don't see it anywhere in https://contentauth.github.io/c2pa-android/c2pa-android/org.contentauth.c2pa/index.html and search doesn't return any hits either.
I would assume due to its location that it should be incorporated into the generated docs, but If it's actually meant for consumption in GitHub, then there are some minor formatting issues that should be fixed and it should be probably be moved to better location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module name at the top of the file needed to be changed to exactly match the package. Now that that's done, the intro is showing on the site: https://contentauth.github.io/c2pa-android/
Happy to make any formatting changes.
|
I'm going to merge this, but we need to remember to change this at some point to build/publish docs only on a release, rather than on push to main/docs branches. |
Changes in this pull request
Adds inline docs to library files and provides a CI workflow to publish them to Github Pages.
Types of changes
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment