Plus Codes #5116
Open
Plus Codes #5116
+143
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0xsh
force-pushed
the
feat/plus-codes
branch
from
432ef53 to
7a6f241
Compare
r0xsh
force-pushed
the
feat/plus-codes
branch
from
ee8173e to
41691c5
Compare
r0xsh
force-pushed
the
feat/plus-codes
branch
from
76fe575 to
714a74d
Compare
r0xsh
force-pushed
the
feat/plus-codes
branch
from
714a74d to
8bb5612
Compare
Member
Author
|
Check whats wrong with tests |
alexsegura
reviewed
Dec 24, 2025
| } | ||
|
|
||
| // Check if the input is a plus code - takes priority over all adapters | ||
| const plusCodeMatch = value.match(/\b[23456789CFGHJMPQRVWX]{2,8}\+[23456789CFGHJMPQRVWX]{2,4}\b/i) |
Member
Author
There was a problem hiding this comment.
Oh yep, it seems a bit more precise, ty
Member
Author
There was a problem hiding this comment.
Also i used mine since it allow some flexbility. You can write "FFDDD+2223, Ghana" and it will still match. The regex in the doc is a bit more strict and only allow the plus code part.
This is useful since copying it from gmaps for exemple, will add those suffix
| } | ||
|
|
||
| // Check if the input is a plus code - takes priority over all adapters | ||
| const plusCodeMatch = value.match(/\b[23456789CFGHJMPQRVWX]{2,8}\+[23456789CFGHJMPQRVWX]{2,4}\b/i) |
Member
There was a problem hiding this comment.
Why not use OpenLocationCode.isValid here?
Member
Author
There was a problem hiding this comment.
The isValid don't allow to check for a specific resolution. You can use a very low resolution for example 1km² and will still be valid.. since this resolution is in the plus codes spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.