-
Notifications
You must be signed in to change notification settings - Fork 4
Add emulator controls to sidebar #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Paul Chanvin <paul@paulchanvin.fr>
|
Marking it as ready for review mostly for design feedback. Commit history can be cleaned up if needed |
|
Tested in codespace.
Marking this PR as ready for review still. |
|
Functional in codespace with this PR : #4 PR is separated from this one because it relies on modifications of the pebble-tool. This present PR doesn't rely on those. so it can be merged as is. |
|
@jplexer I am unable to request a review here, could you check this? |
jplexer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome!
This PR adds a 'TreeView' in the extension sidebar to quickly get access to emulator controls, such as :
Closes #2
WorksOnMyMachine
Test in DevContainer / Github Codespace
Making EmuAppConfig work in Github Codespace