translate: downgrade translation from v35 to v34 #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasminvalim
force-pushed
the
downgrade-v35-to-v34
branch
2 times, most recently
from
114c67d to
f46dc44
Compare
yasminvalim
force-pushed
the
downgrade-v35-to-v34
branch
2 times, most recently
from
bb89cfa to
22455e2
Compare
prestist
reviewed
Nov 22, 2024
Contributor
prestist
left a comment
prestist
left a comment
There was a problem hiding this comment.
From first glance everything makes sense, I have a question, it might just be a copy pasta error, but want to verify.
yasminvalim
force-pushed
the
downgrade-v35-to-v34
branch
from
22455e2 to
87662a5
Compare
HuijingHei
reviewed
Nov 25, 2024
Member
|
Sorry that I am a little confused, is there any requirement / context that we should do the downgrade? |
Member
If I remember correctly, this is used by the MCO to translate configs as needed to a version that will be understood by a node. |
yasminvalim
force-pushed
the
downgrade-v35-to-v34
branch
from
87662a5 to
b4cb29a
Compare
prestist
approved these changes
Nov 25, 2024
Contributor
prestist
left a comment
prestist
left a comment
There was a problem hiding this comment.
Thank you for adding this, it lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this task, we need to vendor the updates from Ignition's new spec and then implement downgrade logic to transition from version 35 to version 34 and add unit tests for it. For reference, you can check the example provided #41.