Skip to content

Conversation

@acardace
Copy link
Contributor

This will work together with the owners-file-action once coreos/repo-templates#334 gets merged.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an OWNERS file to specify approvers and reviewers for the repository. The file structure is straightforward. For improved long-term maintainability, I recommend sorting the lists of approvers and reviewers alphabetically. This will make it easier to manage these lists as they grow and change over time.

Comment on lines 1 to 11
approvers:
- prestist
- yasminvalim
- dustymabe
- travier
reviewers:
- joelcapitao
- HuijingHei
- marmijo
- aaradhak
- tlbueno

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it's good practice to keep lists of owners sorted alphabetically. This makes it easier to find names and helps prevent duplicates as the lists grow.

approvers:
    - dustymabe
    - prestist
    - travier
    - yasminvalim
reviewers:
    - aaradhak
    - HuijingHei
    - joelcapitao
    - marmijo
    - tlbueno

@travier travier added the skip-notes This PR does not need release notes label Dec 12, 2025
This will work together with the owners-file-action once coreos/repo-templates#334
gets merged.
@prestist
Copy link
Collaborator

prestist commented Dec 12, 2025

Okay this makes sense, though did you think about having the owners be a part of the actual repo-templates rendor? kinda like how we render out the md files per repo?

see: coreos/repo-templates#334 (comment)

Copy link
Collaborator

@prestist prestist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prestist prestist merged commit e7e9ce1 into main Dec 17, 2025
10 checks passed
@prestist prestist deleted the add-owners branch December 17, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-notes This PR does not need release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants