-
Notifications
You must be signed in to change notification settings - Fork 270
Add OWNERS file #2176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OWNERS file #2176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an OWNERS file to specify approvers and reviewers for the repository. The file structure is straightforward. For improved long-term maintainability, I recommend sorting the lists of approvers and reviewers alphabetically. This will make it easier to manage these lists as they grow and change over time.
| approvers: | ||
| - prestist | ||
| - yasminvalim | ||
| - dustymabe | ||
| - travier | ||
| reviewers: | ||
| - joelcapitao | ||
| - HuijingHei | ||
| - marmijo | ||
| - aaradhak | ||
| - tlbueno |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability, it's good practice to keep lists of owners sorted alphabetically. This makes it easier to find names and helps prevent duplicates as the lists grow.
approvers:
- dustymabe
- prestist
- travier
- yasminvalim
reviewers:
- aaradhak
- HuijingHei
- joelcapitao
- marmijo
- tlbueno
This will work together with the owners-file-action once coreos/repo-templates#334 gets merged.
|
Okay this makes sense, though did you think about having the owners be a part of the actual repo-templates rendor? kinda like how we render out the md files per repo? |
prestist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This will work together with the owners-file-action once coreos/repo-templates#334 gets merged.