Overhaul of convert_project and related tools#724
Draft
mattmccutchen-cci wants to merge 3 commits intomainfrom
Draft
Overhaul of convert_project and related tools#724mattmccutchen-cci wants to merge 3 commits intomainfrom
convert_project and related tools#724mattmccutchen-cci wants to merge 3 commits intomainfrom
Conversation
Currently, the settings.json file is just a distraction. If we want to add back support for the normal Checked C clangd or some future specialized 3C clangd, we can revert this commit if we want to, but it's more likely that we'll need something different anyway.
- Remove convert_individual.sh: We haven't used this in a long time, and I don't think it's very useful. At this point, we're pretty committed to running 3C on all files to take advantage of cross-file information, and even if we wanted to run it on one file, convert_individual.sh likely wouldn't be exactly what we want. - Remove nmake workaround: I don't think we use this any more. - convert_all.sh: Use a bash array literal to make it easier for the user to comment out individual lines. (I've been wanting this for a while.)
Factor out code to be used by utils-5c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm planning to do a few things in this PR:
convert_projectand removal of obsolete code/features.generate_ccommands.pyso it can be used by the macro expander CLI (see below) and byutils-5c.argumentsfield (fixes Ensure thatconvert_projectworks with compilation databases that use thecommandfield #720).This needs a lot more work and testing, but I'm going ahead and posting it in case anyone is curious. The corresponding draft PR for
utils-5cis correctcomputation/utils-5c#19.