Merged
Conversation
…to specs to dispose of test certificates.
…entIdentityConfiguration
idg10
reviewed
Mar 27, 2024
Contributor
idg10
left a comment
idg10
left a comment
There was a problem hiding this comment.
We should probably bump the minor version, since this adds new functionality.
We should also add release notes.
- Enhanced `pr-autoflow.json` to include new packages and remove wildcards. - Modified `dependabot.yml` to exclude certain patterns for updates. - Updated `auto_release.yml` with a new action version for improved retry logic. - Introduced `build.yml` for a structured build process with concurrency settings. - Updated `.gitignore` to ignore `.sbom.*` files in `local.settings.json`. - Enhanced `config.ps1` with comments and examples for the build process. - Updated `GitVersion.yml` to include `main` as a source branch and changed the next version to `4.0`. - Changed target framework from `net6.0` to `net8.0` for several projects. - Updated package references to newer versions for various libraries. - Refactored initialization of `HashSet` and `List` in several files for modern syntax. - Replaced NUnit assertions with `Assert.That` for better readability in tests. - Refactored token provider classes for improved dependency injection handling. - Extensively modified `packages.lock.json` for updated dependencies. - Refactored test files for clarity and maintainability, removing obsolete code.
- Bumped `Endjin.RecommendedPractices.GitHub` to version `2.1.18` in both `Corvus.Identity.Abstractions.csproj` and `Corvus.Identity.Certificates.csproj`. - Changed target frameworks in `Corvus.Identity.Certificates.csproj` to only support `.NET 8.0`. - Removed obsolete package references and updated `Microsoft.Extensions.DependencyInjection.Abstractions` to a compatible version range. - Added `Corvus.Identity.Certificates` as a project dependency in `packages.lock.json`. - Updated `BouncyCastle.Cryptography` from `2.3.0` to `2.6.1` in `Corvus.Identity.Specs.csproj`. - Removed obsolete SpecFlow code behind files from `Corvus.Identity.Specs.csproj`. - Modified `LoadJsonConfiguration` method in `ConfigLoading.cs` to return a nullable type.
idg10
reviewed
Jun 13, 2025
| <PrivateAssets>all</PrivateAssets> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
| </PackageReference> | ||
| <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="[8.0.*,)" /> |
Contributor
There was a problem hiding this comment.
These [,) style version specs turned out to be a mistake. I misunderstood what they did back when I introduced them, and I've been gradually removing them since.
At the time I thought these got written into the NuGet package. Turns out they don't: they get resolved at compile time to a specific version, meaning that the build is no longer deterministic. (If a new version comes out, you'll get that, meaning that the resulting NuGet package is different from what would have been built before that new version came out despite no change in source code.)
This form of package spec really only makes sense in applications (and test suites); in a library, it turns out to be no more useful than hard-coding it, with the added feature of making builds non-repeatable.
Changed version specifications for several Microsoft.Extensions packages from a range format (e.g., `[8.0.*, )`) to a wildcard format (e.g., `8.*`). This update was applied across multiple project files and the `packages.lock.json` file to allow for greater flexibility in package versioning.
idg10
reviewed
Jun 13, 2025
| @@ -1,5 +1,19 @@ | |||
| # Release notes for Corvus.Identity v3. | |||
|
|
|||
| ## v3.4 | |||
Contributor
There was a problem hiding this comment.
I just realised that we're already post v4 aren't we? The GitVersion.yml has v4 in it. In which case this should be going into a new Corvus.Identity.v4.md file.
idg10
approved these changes
Jun 13, 2025
Contributor
idg10
left a comment
idg10
left a comment
There was a problem hiding this comment.
v3 -> v4 release notes aside, this now LGTM
…thentication support and .NET 8.0 migration
idg10
approved these changes
Jun 13, 2025
Code Coverage Summary Report - Linux (No TFM)Summary
CoverageCorvus.Identity.Abstractions - 100%
Corvus.Identity.Azure - 83.7%
Corvus.Identity.Certificates - 100%
Corvus.Identity.Specs - 93.2%
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.