Update dependencies and configuration for Azure Functions#333
Merged
HowardvanRooijen merged 6 commits intomainfrom Jun 6, 2025
Merged
Update dependencies and configuration for Azure Functions#333HowardvanRooijen merged 6 commits intomainfrom
HowardvanRooijen merged 6 commits intomainfrom
Conversation
- Modified `build.yml` to use GitHub SHA for concurrency. - Updated `Endjin.RecommendedPractices.GitHub` to version 2.1.18 in multiple projects. - Upgraded `Azure.Identity` to version 1.14.0 and adjusted version specifications for related packages. - Changed credential type in `AzureTokenCredentialSourceFromConfiguration.cs` for Visual Studio Code. - Updated `local.settings.template.json` to use `dotnet-isolated` for Azure Functions. - Reflected new package versions in `packages.lock.json`, ensuring compatibility. - Added new testing dependencies and removed outdated ones in `packages.lock.json`.
Changed the expected type of the `TokenCredential` from 'VisualStudioCodeCredential' to 'AzureCliCredential' in the Visual Studio Code credential configuration test as VisualStudioCodeCredential is now obsolete.
Clarified the deprecation notice in the switch statement for `ClientIdentitySourceTypes.VisualStudioCode`, correcting the reference from `VisualStuCredential` to `VisualStudioCodeCredential`.
…tnet/Corvus.Identity into feature/update-2025-06
jongeorge1
reviewed
Jun 6, 2025
.../Identity/ClientAuthentication/Azure/Internal/AzureTokenCredentialSourceFromConfiguration.cs
Outdated
Show resolved
Hide resolved
This commit updates the `Corvus.Identity.ClientAuthentication.Azure` namespace by: - Changing the initialization of `indicatedSourceTypes` in `ClientIdentityConfigurationValidation.cs` to use an empty array. - Modifying the handling of `configuration.IdentitySourceType` to use array syntax in the `Except` method. - Marking the `VisualStudioCode` enum value as obsolete in `ClientIdentitySourceTypes.cs`, recommending the use of `AzureCli` instead. - Correcting a typo in `IAzureTokenCredentialSource.cs`. - Removing the mapping for `ClientIdentitySourceTypes.VisualStudioCode` in `AzureTokenCredentialSourceFromConfiguration.cs`. - Updating the `SimpleSourceTypes.feature` file to reflect the deprecation of `VisualStudioCode` and adding a scenario to ignore related tests.
Code Coverage Summary Report - Linux (No TFM)Summary
CoverageCorvus.Identity.Abstractions - 100%
Corvus.Identity.Azure - 81.9%
Corvus.Identity.Specs - 91.7%
|
jongeorge1
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.ymlto use GitHub SHA for concurrency.Endjin.RecommendedPractices.GitHubto version 2.1.18 in multiple projects.Azure.Identityto version 1.14.0 and adjusted version specifications for related packages.AzureTokenCredentialSourceFromConfiguration.csfor Visual Studio Code.local.settings.template.jsonto usedotnet-isolatedfor Azure Functions.packages.lock.json, ensuring compatibility.packages.lock.json.