Add YAML support to the source generator#659
Open
jing8956 wants to merge 3 commits intocorvus-dotnet:mainfrom
Open
Add YAML support to the source generator#659jing8956 wants to merge 3 commits intocorvus-dotnet:mainfrom
jing8956 wants to merge 3 commits intocorvus-dotnet:mainfrom
Conversation
|
|
mwadams
reviewed
Jan 9, 2026
Contributor
mwadams
left a comment
mwadams
left a comment
There was a problem hiding this comment.
This looks really good.
One performance related comment.
| if (string.Equals(extensions, ".yaml", StringComparison.InvariantCultureIgnoreCase) | ||
| || string.Equals(extensions, ".yml", StringComparison.InvariantCultureIgnoreCase)) | ||
| { | ||
| YamlDotNet.Serialization.IDeserializer deserializer = |
Contributor
There was a problem hiding this comment.
It is important to minimize the amount of work done in the source generator.
We should build the serializer and deserializer instances once and use static instances, rather than creating them on the fly every time we generate source.
Author
There was a problem hiding this comment.
@mwadams Done. jing8956@50d2e88
Rebased onto the latest commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add YAML support to the
Corvus.Json.SourceGenerator