-
Notifications
You must be signed in to change notification settings - Fork 5
DA-1275: Added tags for llamaindex vector search cookbook tutorial #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @VirajAgarwal1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the 'LlamaIndex' tag to the system's configuration for validating markdown frontmatter. This change is essential for properly categorizing and validating content, specifically for tutorials related to LlamaIndex vector search, ensuring that new documentation can correctly utilize this tag. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the LlamaIndex tag to the list of accepted tags for markdown frontmatter validation. My review includes a suggestion to sort the list of tags alphabetically and format it for better readability and maintainability. This will make it easier to manage the list as more tags are added in the future.
| const sdk_languages = ['nodejs', 'scala', 'python', 'swift', 'csharp', 'objective-c', 'android-java', 'any', 'java', 'kotlin', 'dart', 'golang', 'c++'] | ||
|
|
||
| const tags = ['Ottoman', 'Ktor', 'REST API', 'Express', 'Flask', 'TLS', 'Configuration', 'Next.js', 'iOS', 'Xcode', '.NET', 'Xamarin', 'Authentication', 'OpenID', 'Keycloak', 'Android', 'P2P', 'UIKit', 'Installation', 'Spring Boot', 'Spring Data', 'Transactions', 'SQL++ (N1QL)', 'Optimization', 'Community Edition', 'Docker', 'Data Modeling', 'Metadata', 'Best Practices', 'Data Ingestion', 'Kafka', 'Support', 'Customer', 'Prometheus', 'Monitoring', 'Observability', 'Metrics', 'Query Workbench', 'ASP.NET', 'linq', 'DBaaS', 'App Services', 'Flutter', 'Gin Gonic', 'FastAPI', 'LangChain', "OpenAI", "Streamlit", 'Google Gemini', 'Nvidia NIM', 'LLama3', 'AWS', 'Artificial Intelligence', 'Cohere', 'Jina AI', 'Mistral AI', 'Ragas', 'Haystack', 'LangGraph', 'Amazon Bedrock', 'CrewAI', 'PydanticAI', 'C++', 'C++ SDK', 'smolagents', 'Ag2', 'Autogen', 'Couchbase Edge Server', 'Deepseek', 'OpenRouter', 'mastra', 'Looker Studio', 'Google Data Studio', 'Connector', 'Couchbase Columnar', 'TAVs', 'Custom Queries', 'Data API', 'FTS', 'GSI', 'Hugging Face'] | ||
| const tags = ['Ottoman', 'Ktor', 'REST API', 'Express', 'Flask', 'TLS', 'Configuration', 'Next.js', 'iOS', 'Xcode', '.NET', 'Xamarin', 'Authentication', 'OpenID', 'Keycloak', 'Android', 'P2P', 'UIKit', 'Installation', 'Spring Boot', 'Spring Data', 'Transactions', 'SQL++ (N1QL)', 'Optimization', 'Community Edition', 'Docker', 'Data Modeling', 'Metadata', 'Best Practices', 'Data Ingestion', 'Kafka', 'Support', 'Customer', 'Prometheus', 'Monitoring', 'Observability', 'Metrics', 'Query Workbench', 'ASP.NET', 'linq', 'DBaaS', 'App Services', 'Flutter', 'Gin Gonic', 'FastAPI', 'LangChain', "OpenAI", "Streamlit", 'Google Gemini', 'Nvidia NIM', 'LLama3', 'AWS', 'Artificial Intelligence', 'Cohere', 'Jina AI', 'Mistral AI', 'Ragas', 'Haystack', 'LangGraph', 'Amazon Bedrock', 'CrewAI', 'PydanticAI', 'C++', 'C++ SDK', 'smolagents', 'Ag2', 'Autogen', 'Couchbase Edge Server', 'Deepseek', 'OpenRouter', 'mastra', 'Looker Studio', 'Google Data Studio', 'Connector', 'Couchbase Columnar', 'TAVs', 'Custom Queries', 'Data API', 'FTS', 'GSI', 'Hugging Face', 'LlamaIndex'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability and to avoid duplicates, it's a good practice to keep this list of tags sorted alphabetically. Additionally, formatting the array with one tag per line will improve readability and make future changes easier to review.
const tags = [
'.NET',
'Ag2',
'Amazon Bedrock',
'Android',
'App Services',
'Artificial Intelligence',
'ASP.NET',
'Authentication',
'Autogen',
'AWS',
'Best Practices',
'C++',
'C++ SDK',
'Cohere',
'Community Edition',
'Configuration',
'Connector',
'Couchbase Columnar',
'Couchbase Edge Server',
'CrewAI',
'Customer',
'Custom Queries',
'Data API',
'Data Ingestion',
'Data Modeling',
'DBaaS',
'Deepseek',
'Docker',
'Express',
'FastAPI',
'Flask',
'Flutter',
'FTS',
'Gin Gonic',
'Google Data Studio',
'Google Gemini',
'GSI',
'Haystack',
'Hugging Face',
'Installation',
'iOS',
'Jina AI',
'Kafka',
'Keycloak',
'Ktor',
'LangChain',
'LangGraph',
'linq',
'LLama3',
'LlamaIndex',
'Looker Studio',
'mastra',
'Metadata',
'Metrics',
'Mistral AI',
'Monitoring',
'Next.js',
'Nvidia NIM',
'Observability',
'OpenAI',
'OpenID',
'OpenRouter',
'Optimization',
'Ottoman',
'P2P',
'Prometheus',
'PydanticAI',
'Query Workbench',
'Ragas',
'REST API',
'smolagents',
'Spring Boot',
'Spring Data',
'SQL++ (N1QL)',
'Streamlit',
'Support',
'TAVs',
'TLS',
'Transactions',
'UIKit',
'Xamarin',
'Xcode'
]
LlamaIndextag