-
Notifications
You must be signed in to change notification settings - Fork 8
DA-1320 Updates according to latest docs for Hugging Face #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Caution Notebooks or Frontmatter Files Have Been Modified
4 Notebook Files Modified:
5 Frontmatter Files Modified:
|
Summary of ChangesHello @azaddhirajkumar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the Hugging Face embeddings tutorials for Couchbase vector search by updating all references and examples to reflect the latest Couchbase vector index terminology. It renames directories and files, revises the content of Jupyter notebooks to introduce Hyperscale, Composite, and Search Vector Indexes, and cleans up notebook execution outputs, ensuring the documentation is current and accurate. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a comprehensive update to the Hugging Face tutorials, aligning them with the latest Couchbase terminology. The changes from GSI/FTS to Hyperscale/Composite/Search Vector Indexes are applied consistently across documentation, notebooks, and file structures. The cleanup of Jupyter notebooks by removing outputs and execution counts is also a good improvement for repository hygiene.
I have one suggestion regarding a dependency in one of the notebooks to ensure future reproducibility. Overall, this is a solid update.
| "outputs": [], | ||
| "source": [ | ||
| "!pip install --quiet langchain-couchbase==0.5.0 transformers==4.56.1 sentence_transformers==5.1.0 langchain_huggingface==0.3.1 python-dotenv==1.1.1 ipywidgets" | ||
| "!pip install --quiet langchain-couchbase==1.0.1 transformers==4.56.1 sentence_transformers==5.1.0 langchain_huggingface python-dotenv==1.1.1 ipywidgets" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the sake of reproducibility of this tutorial, it's a good practice to pin the version of all dependencies. The langchain_huggingface package is not pinned, which could lead to issues if a future version introduces breaking changes. This is also inconsistent with huggingface/search_based/hugging_face.ipynb where langchain_huggingface is pinned.
Consider pinning it to a specific version, for example, the previously used 0.3.1 if it's compatible with langchain-couchbase==1.0.1, or a newer known-to-work version.
| "!pip install --quiet langchain-couchbase==1.0.1 transformers==4.56.1 sentence_transformers==5.1.0 langchain_huggingface python-dotenv==1.1.1 ipywidgets" | |
| "!pip install --quiet langchain-couchbase==1.0.1 transformers==4.56.1 sentence_transformers==5.1.0 langchain_huggingface==0.3.1 python-dotenv==1.1.1 ipywidgets" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be compatible with latest version.
VirajAgarwal1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a small change needed for the merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Output for the Code blocks is needed to show the performance in the test section
No description provided.