-
Notifications
You must be signed in to change notification settings - Fork 19
[DOC-13488]: Feedback on Create a Vector Search Index with the Server Web Console | Couchbase Docs #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/8.0
Are you sure you want to change the base?
Conversation
… Web Console | Couchbase Docs Clarified the section on adding a child mapping. Added a few pictures to make it clear what's going on. Signed-off-by: Ray Offiah <ray.offiah@couchbase.com>
sarahlwelton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm willing to entertain a good argument for the images, but I'm not down with the style issues. Please fix. :)
| .. Select the [.ui]*only index specified fields* checkbox. | ||
| .. Unset the [.ui]*#default* field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .. Select the [.ui]*only index specified fields* checkbox. | |
| .. Unset the [.ui]*#default* field | |
| .. Under the collection name, select *only index specified fields*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RayOffiah Please don't just mark this as resolved and ignore it - why do you want to word it this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you at least please remove the [.ui] attribute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, my mistake; I think I miskeyed; I was going to accept the change, but now I think about, I think I prefer my version.
The reason DOC-13488 was filed in the first place was that the filer(?) thought that the original text was asking him to look a set of specified fields:
Regarding these instructions - it says "Only index specified fields". What fields? Specified where?
I would prefer to make it clear that he's looking for a checkbox.
But I can remove the [.ui] attributes.
| . Create a child field mapping on the new collection type mapping: | ||
|
|
||
| .. Using the mouse over, hover over the [.ui]*Field* item, then click on the btn:[{plus}] button. | ||
| .. Select menu:insert child field[] from the dropdown menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .. Select menu:insert child field[] from the dropdown menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We covered this in the previous step, this needs to be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeees, I'd rather keep this one, if you don't mind; the UI hides the function until you mouse over it, which confused the fella who submitted the initial Jira request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also don't refer to dropdowns like this: https://docs.couchbase.com/styleguide/dropdowns.html
In general, I would say this is a menu, which is why I said to use the menu:[] macro to render it as + > insert child field: https://docs.couchbase.com/styleguide/menus.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you're navigating in the menu? We're telling them to do the same thing twice if you leave this as is. Try and rebuild the site with this suggestion in place and you'll see what I mean.
They don't need to click insert child field twice, and this is what it's telling them to do right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes; got it now.
modules/vector-search/images/only-index-specified-field-checkbox.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one is helpful, so I think I'd rather keep it, if that's okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said, open to the arguments for keeping them - I'm okay with 1 screenshot for the tricky "this is where the menu is", but 3 felt like overkill :)
rao-shwe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
sarahlwelton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One additional thing.
Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
Co-authored-by: sarahlwelton <110928505+sarahlwelton@users.noreply.github.com>
sarahlwelton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes still need to be made, please.
| .. Select the [.ui]*only index specified fields* checkbox. | ||
| .. Unset the [.ui]*#default* field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RayOffiah Please don't just mark this as resolved and ignore it - why do you want to word it this way?
| . Create a child field mapping on the new collection type mapping: | ||
|
|
||
| .. Using the mouse over, hover over the [.ui]*Field* item, then click on the btn:[{plus}] button. | ||
| .. Select menu:insert child field[] from the dropdown menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We covered this in the previous step, this needs to be deleted.
| . Create a child field mapping on the new collection type mapping: | ||
|
|
||
| .. Using the mouse over, hover over the [.ui]*Field* item, then click on the btn:[{plus}] button. | ||
| .. Select menu:insert child field[] from the dropdown menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also don't refer to dropdowns like this: https://docs.couchbase.com/styleguide/dropdowns.html
In general, I would say this is a menu, which is why I said to use the menu:[] macro to render it as + > insert child field: https://docs.couchbase.com/styleguide/menus.html
80b59fc to
acf2386
Compare
acf2386 to
8bbeb46
Compare
… Web Console | Couchbase Docs Changes following reviews.
430d86e to
0705d26
Compare
sarahlwelton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style guidance does want us to not refer to "checkbox" specifically, and I think we could have avoided it on Line 61, specifically.
We can always revisit this in a future discussion about style.
But, just one more thing to fix in this PR, just to make sure we're not repeating ourselves. I'll be happy to remove my Request Changes once we get this sorted.
Thanks for your patience, @RayOffiah :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said, open to the arguments for keeping them - I'm okay with 1 screenshot for the tricky "this is where the menu is", but 3 felt like overkill :)
| .. In the *Collection* list, select the collection that contains the documents you want to include in your index. | ||
| .. Select *Only index specified fields*. | ||
| .. Select the *only index specified fields* checkbox. | ||
| .. Unset the *#default* field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, if we're telling them to "clear the default type mapping" further down, I don't think we need this step. It's the same thing, right?
Clarified a few of the pain points around creating fields and mappings.
Added screenshots to hide options hidden within the UI.
Preview URL:
https://preview.docs-test.couchbase.com/docs-devex-DOC-13488-Feedback-on-Create-a-Vector-Search-Index-with-the-Server-Web-Console--Couchbase-Docs
You will need the Docs Team credentials on Confluence.