Skip to content

Take in middleware factory rather than middleware #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cliu587 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Take in middleware factory rather than middleware #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...aphql/src/main/scala/org/coursera/naptime/ari/graphql/controllers/GraphQLController.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class GraphQLController @Inject()(
fetcher: FetcherApi,
filterList: FilterList,
metricsCollector: GraphQLMetricsCollector,
additionalMiddlewares: List[Middleware[Any]])(implicit ec: ExecutionContext)
additionalMiddlewareFactories: List[() => Middleware[Any]])(implicit ec: ExecutionContext)
extends InjectedController
with StrictLogging {

Expand Down Expand Up @@ -129,6 +129,7 @@ class GraphQLController @Inject()(
case Success(queryAst) =>
val baseFilter: IncomingQuery => Future[OutgoingQuery] = (incoming: IncomingQuery) => {
val context = SangriaGraphQlContext(fetcher, requestHeader, ec, incoming.debugMode)
val additionalMiddlewares = additionalMiddlewareFactories.map(factory => factory.apply)
Executor
.execute(
graphqlSchemaProvider.schema,
Expand Down
2 changes: 1 addition & 1 deletion version.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version in ThisBuild := "0.9.2-alpha28"
version in ThisBuild := "0.9.2-alpha29"