Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ would do this:

```ruby
client = ActiveCampaign.client
contact = ActiveCampaign::Contact.new(email: "hi@example.com")
contact = ActiveCampaign::Contact.new(params: {email: "hi@example.com", first_name: "Tester"})
client.create!(contact)
```

Expand Down
4 changes: 0 additions & 4 deletions lib/active_campaign/contact.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@

module ActiveCampaign
class Contact < Resource
def initialize(email:, **params)
@params = params.merge(email: email)
end

action find: :contact_view_email
action create: :contact_add
action update: :contact_edit
Expand Down
10 changes: 9 additions & 1 deletion lib/active_campaign/resource.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,15 @@
module ActiveCampaign
class Resource
def initialize(**params)
@params = params
@params = format_params(params)
end

def format_params(params)
raise "no email attribute included in params" if params[:email].nil?

params.map do |k, v|
[:email, :phone].include?(k) ? [k, v] : ["%#{k.upcase}%, 0".to_sym, v]
end.to_h
end

attr_reader :params
Expand Down
11 changes: 10 additions & 1 deletion test/active_campaign/resource_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class ActiveCampaign::ResourceTest < Minitest::Test
action action_name => action_mapping
end
end
let(:params) { {} }
let(:params) { { email: "testing@email.com" } }
subject { resource.new(params) }

describe "actions" do
Expand All @@ -28,5 +28,14 @@ class ActiveCampaign::ResourceTest < Minitest::Test
end
end
end

describe "when no email param" do
let(:params) { {} }
it "raises an error" do
assert_raises RuntimeError do
subject.action(action_name)
end
end
end
end
end