Skip to content

Make it work with rails 7#9

Open
Mandawi wants to merge 3 commits intocoverhound:masterfrom
Mandawi:patch-1
Open

Make it work with rails 7#9
Mandawi wants to merge 3 commits intocoverhound:masterfrom
Mandawi:patch-1

Conversation

@Mandawi
Copy link

@Mandawi Mandawi commented Jul 25, 2022

makes gem work with rails 7; currently getting:

Bundler could not find compatible versions for gem "railties":
  In snapshot (Gemfile.lock):
    railties (= 7.0.3.1)

  In Gemfile:
    camel_patrol (= 1.1.1) was resolved to 1.1.1, which depends on
      railties (< 6.0, >= 4.1.0)

    rails (~> 7.0.2, >= 7.0.2.4) was resolved to 7.0.3.1, which depends on
      railties (= 7.0.3.1)

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

@schinery
Copy link

You need to update spec.add_dependency "railties", ">= 4.1.0", "< 6.0" in the .gemspec for this to support Rails 7. Seeing as Rails 4 is no longer supported I'd probably go with spec.add_dependency "railties", ">= 5", "< 8" and remove the Rails 5 check in lib/camel_patrol/middleware.rb.

@Mandawi
Copy link
Author

Mandawi commented Aug 13, 2022

Thanks for the info! Just did the updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants