Skip to content

Conversation

@dsf86
Copy link
Collaborator

@dsf86 dsf86 commented Oct 27, 2025

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

HymanShi and others added 30 commits September 22, 2025 19:46
(LogID: 2025092312090101009108820949935E9)

Co-Authored-By: Coda <coda@bytedance.com>
(LogID: 2025092312090101009108820949935E9)

Co-Authored-By: Coda <coda@bytedance.com>
(LogID: 2025092312090101009108820949935E9)

Co-Authored-By: Coda <coda@bytedance.com>
Change-Id: I0efae3f7af582460e46ba629c0f470a10c326025
…ationSet, GetEvaluationSet, ListEvaluationSets

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <coda@bytedance.com>
… convertor

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <coda@bytedance.com>
…ic to separate methods

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <coda@bytedance.com>
…rate methods

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <coda@bytedance.com>
…unified method parameter

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <coda@bytedance.com>
…error tracking

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <coda@bytedance.com>
…DTO/xxxDTO2DO convention

(LogID: 202509281948170100910941219983125)

Co-Authored-By: Coda <coda@bytedance.com>
Change-Id: Ibfa77af15a79fc83b6fb5adc44dd132682fe1c05
…rchitecture

(LogID: 20250928231227010091094121028E1E4)

Co-Authored-By: Coda <coda@bytedance.com>
Change-Id: I54219f18349d50551302a3129d08ea25f1e15fa1
Change-Id: I4fc1842aea80465df2bfe1d9c7044905b7380cf1
Change-Id: Ic99ec4e867794d8f6d98c1d4bcad118158bb6969
Change-Id: I7d83bcded9ee778cd4baf63b2682053b88f42b44
Change-Id: Icbeb24eeebd9d6d5d67e1038b0f4acfce9d5759a
Change-Id: I7a78d11c6b3bdd59bb9a08d5cd9daf893c8afa15
Change-Id: I264264a0e8bbf776341fc2149377b7ba934d1c61
Change-Id: Iac21bc6194af354d9c4ad3a0e1a528cccd0f0c4f
Change-Id: I7972ba4c3b4b812652b86187366c2fdd03c7763e
Change-Id: I673a5dc343764edf228ec5d8a8219f0659d8278d
Change-Id: Ie1e50446c90172aea7292f134b117a37a84f0bce
Change-Id: Ia048d5d8836418597fa6ec48c602fbf48e197643
Change-Id: Ic21981040de379923d8a216a0f8fcf9b543072e6
dsf86 and others added 16 commits October 24, 2025 14:17
Change-Id: Iacd6df5a12b28cef7e8b3be76bf7e1e02ede0102
(LogID: 20251026112148192168001003073C0F4)

Co-Authored-By: Coda <coda@bytedance.com>
Change-Id: I162c280ddaca914e7c5e74c2dfdd881da3921cc6
Change-Id: Id1c3b2d366c4c0de0f2916b531f4d8c6ac2b2734
Change-Id: I746f82aabd482b48f308062a7537e1bb03573e3c
Change-Id: Id42a353bdb928977cffac37cbe4ba2c44d89866a
(LogID: 202510261432441921680010035228DDE)

Co-Authored-By: Coda <coda@bytedance.com>
Change-Id: I97c8c9ed5f7624580d2cdccba8398f3b97c85c57
Change-Id: I16a1394984c471fd00d93232f4add4a34d2c9932
Change-Id: I8222e498f8ebf23c00442d38d43f92c985352d11
Change-Id: I4bac1fad25dcc24397a6d91b7ee964215603bfa7
Change-Id: I2b2ef8380bcf7997d3c8119716eee4ac77c0ab33
Change-Id: I1e2e724d6aa423fd0f8d416f51400a8961f3c0cf
Change-Id: I2385b811cfcee408f7602879eb77c8c6aa55ca0d
Change-Id: Ia08107bc3efef69d74b69843ea9221b7310637af
Change-Id: I0cdf77c3472c7690f17314abb51e9622d190508b
Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitting review: flagged 3 [🚫Must-Fix] issues (IDL contract regression for span_ids; invalid YAML trailing commas and missing span types in both Docker and Helm configs).

Change-Id: I13b1a8c03fe6a03004c8715f512627c7cc7bcb8a
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 82 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...modules/evaluation/application/eval_openapi_app.go 90.78% 17 Missing and 17 partials ⚠️
...api/handler/coze/loop/apis/eval_open_apiservice.go 0.00% 21 Missing ⚠️
...d/modules/evaluation/infra/metrics/openapi/emit.go 46.66% 14 Missing and 2 partials ⚠️
...ckend/modules/evaluation/infra/rpc/data/dataset.go 0.00% 5 Missing ⚠️
...on/application/convertor/evaluation_set/openapi.go 98.94% 2 Missing and 2 partials ⚠️
backend/pkg/kitexutil/kitexutil.go 50.00% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #265       +/-   ##
=========================================
+ Coverage      0   68.02%   +68.02%     
=========================================
  Files         0      568      +568     
  Lines         0    50478    +50478     
=========================================
+ Hits          0    34337    +34337     
- Misses        0    13472    +13472     
- Partials      0     2669     +2669     
Flag Coverage Δ
unittests 68.02% <90.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...on/convertor/evaluation_set/evaluation_set_item.go 46.76% <100.00%> (ø)
...uation/application/convertor/target/eval_target.go 88.88% <100.00%> (ø)
...es/evaluation/domain/entity/evaluation_set_item.go 72.72% <ø> (ø)
backend/modules/evaluation/domain/entity/param.go 54.54% <ø> (ø)
...luation/domain/service/evaluation_set_item_impl.go 100.00% <100.00%> (ø)
backend/pkg/kitexutil/kitexutil.go 50.00% <50.00%> (ø)
...on/application/convertor/evaluation_set/openapi.go 98.94% <98.94%> (ø)
...ckend/modules/evaluation/infra/rpc/data/dataset.go 0.00% <0.00%> (ø)
...d/modules/evaluation/infra/metrics/openapi/emit.go 46.66% <46.66%> (ø)
...api/handler/coze/loop/apis/eval_open_apiservice.go 0.00% <0.00%> (ø)
... and 1 more

... and 557 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c2bc9...9a00d86. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Change-Id: I4d9c5d3e4f282a54d8739e75a02aa4807f677efa
Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted review with inline comments focused on newly added OpenAPI endpoints and IDL syntax issues. Key findings: replace println with structured logging; implement BatchUpdateDatasetItems RPC; fix trailing commas in Thrift IDLs and service method declaration.

dsf86 added 4 commits October 27, 2025 15:28
Change-Id: I26a484af2d02cf1de2ea95d3b566caf1c16bc706
Change-Id: Ifc27956ee3a95e170ff8ffa81f7ab4cb24b6738c
Change-Id: Icb8d61eb5fef0839719ffd4d546620c122a47bbe
Change-Id: I9db44742a63b2194779ee63b9c38ac62baeb605f
@dsf86 dsf86 merged commit 5774a73 into main Oct 29, 2025
19 checks passed
@dsf86 dsf86 deleted the feat/a2a_agentkit branch October 29, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants