Fix batch processing for all Human Parser nodes#33
Open
wzyfromhust wants to merge 1 commit intocozymantis:mainfrom
Open
Fix batch processing for all Human Parser nodes#33wzyfromhust wants to merge 1 commit intocozymantis:mainfrom
wzyfromhust wants to merge 1 commit intocozymantis:mainfrom
Conversation
## Problem All three Human Parser nodes (ATR, LIP, Pascal) had a critical batch processing bug: - When using "Load Image Batch From Dir" to load multiple images, only the first image was processed - All images in the batch received the same parsing result (from image[0]) - This made batch processing completely unusable ## Root Cause The nodes used `generate(image[0], ...)` which forced processing of only the first image in the batch, ignoring all subsequent images. ## Solution Modified all three nodes to properly iterate over the batch: - Process each image individually: `for index in range(len(image))` - Collect results in lists: `ret_masks.append(...)` and `ret_maps.append(...)` - Concatenate outputs: `torch.cat(ret_masks, dim=0)` ## Files Changed - HumanParserATRCustomNode.py - HumanParserLIPCustomNode.py - HumanParserPascalCustomNode.py - test_batch_fix.py (added comprehensive test suite) ## Testing ✅ All tests passed: - Single image mode: backward compatible - Batch mode: each image processed correctly with unique results - Output shapes: correct tensor dimensions - Manual testing: verified with real batch workflow This fix enables proper batch processing workflows in ComfyUI.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All three Human Parser nodes (ATR, LIP, Pascal) had a critical batch processing bug:
Root Cause
The nodes used
generate(image[0], ...)which forced processing of only the first image in the batch, ignoring all subsequent images.Solution
Modified all three nodes to properly iterate over the batch:
for index in range(len(image))ret_masks.append(...)andret_maps.append(...)torch.cat(ret_masks, dim=0)Files Changed
Testing
✅ All tests passed:
This fix enables proper batch processing workflows in ComfyUI.