-
Notifications
You must be signed in to change notification settings - Fork 10
Added Inventory Filter, Inventory Export... #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Inventory can be filtered by weapon type via "Filter by Type" dropdown, you can export Inventory as csv by right-clicking the inventory grid, Gun = 15 added.
Added ability to filter by "World".
Added Hairpin weapon type to SchemaConstants.cs.
client/UI/FFRKViewInventory.cs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you need these lines? The only place this should matter is in the FFRKViewInventory_Load() function, because it can be called by the designer (i.e. when you're in Visual Studio and you load the UI editor). So it exists in the Load function so that when the designer calls it it doesn't crash, but as long as _Load() doesn't call _Recalc in an unprotected block, this should be unnecessary.
Also just as a matter of style, I only really use the _Foo() naming convention for event handlers. For regular helper functions and what not just call it something like Recalculate()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you like this solution, but I added a lower bound and upper bound when filtering types.
If you select a specific type such as "Weapon", then having a lower bound and upper bound may seem unnecessary as you can just check if equip.Type == 1. However, if you want to select "All" you need to include all item numbers within a certain range, so in this case I check if 0 <= equip.Type <= 99.
Export format is specific to http://ffrk-tools.menencia.com/
Adding FFXIV
Added JSON inventory export option
Added ability to filter inventory by item type (Weapon, Armour, Accessory), added ability to export inventory to csv (by right-clicking inventory area), added Gun weapon ID (so it doesn't show as "15" any more), added ability to filter "Item Search" by "World" alone.