Conversation
Still some stuff left to port, but this should help
| "erlpack": "github:hammerandchisel/erlpack", | ||
| "request": "^2.81.0" | ||
| "request": "^2.81.0", | ||
| "winston": "git+https://github.com/winstonjs/winston.git" |
There was a problem hiding this comment.
Any reason you are not including winston by version number here?
There was a problem hiding this comment.
The version in the npm repository is Winston 2, which is being replaced by Winston 3 (the version in the github repository) in the near future.
|
I had a quick look over and so far it looks good to me. The way you are implementing classes makes sense and should make things easier to maintain. I don't usually use typescript in my projects but also don't have any objections to it. I don't know if I will have time to do a proper full review in the near future (as you might have noticed by activity on the project I haven't exactly had a lot of time). I'll see if I can get some other people that use the project to chip in. |
|
There's still quite a bit to be done, so no rush :) |
|
Any progress on this? |
|
It's dead. |
|
Sorry folks, I don't think I'll be working on this anymore. If anyone is inclined, feel free to fork and continue the work :) |
This is an initial proposal of a better structure for the project, as proposed in #51.
src/services/discord.ts- Class that interacts with the Discord clientsrc/services/irc.ts- Class for the IRC server. Still a lot of TODOs, listed intodo.orgutil/SocketEx.ts- A wrapper that promisifiesnet.Socket's asynchronous methods for proper usageutil/parseMessage.ts- Message parsing stuffI also took the liberty of using Typescript, which I believe makes the development process incredibly more comfortable, especially when messing with runtime data types.
I apologize in advance for the bad commit messages. My work is usually all over the place so I never know what to say :p