Adds gRPC health check support#116
Merged
mbrulatout merged 1 commit intocriteo:masterfrom Feb 4, 2026
Merged
Conversation
Contributor
KunxiSun
commented
Feb 4, 2026
- Introduces Check.grpc(...) to configure a gRPC health check for Consul, with optional TLS, timeout and deregistration.
- Maps parameters to Consul health check fields, including:
- required: grpc (URL) and interval
- optional: grpc_use_tls, tls_skip_verify, timeout, DeregisterCriticalServiceAfter
- Adds extensive unit tests covering various combinations of TLS, timeout, and deregistration to ensure correct dict output.
- Aligns with Consul's gRPC health check protocol and expected configuration structure.
mbrulatout
approved these changes
Feb 4, 2026
Contributor
|
Thanks for the PR ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.