Skip to content

Adds gRPC health check support#116

Merged
mbrulatout merged 1 commit intocriteo:masterfrom
KunxiSun:feat/grpc-check
Feb 4, 2026
Merged

Adds gRPC health check support#116
mbrulatout merged 1 commit intocriteo:masterfrom
KunxiSun:feat/grpc-check

Conversation

@KunxiSun
Copy link
Contributor

@KunxiSun KunxiSun commented Feb 4, 2026

  • Introduces Check.grpc(...) to configure a gRPC health check for Consul, with optional TLS, timeout and deregistration.
  • Maps parameters to Consul health check fields, including:
    • required: grpc (URL) and interval
    • optional: grpc_use_tls, tls_skip_verify, timeout, DeregisterCriticalServiceAfter
  • Adds extensive unit tests covering various combinations of TLS, timeout, and deregistration to ensure correct dict output.
  • Aligns with Consul's gRPC health check protocol and expected configuration structure.

@mbrulatout
Copy link
Contributor

Thanks for the PR !
This made me realize this place would need quite a bit of work to add multiple other args to the various HC 😅

@mbrulatout mbrulatout merged commit 11805bc into criteo:master Feb 4, 2026
5 checks passed
@KunxiSun KunxiSun deleted the feat/grpc-check branch February 4, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants