Update baseline profile with DeckPicker onResume journey#8
Open
Galal-20 wants to merge 1 commit intocriticalAY:baseline-profilesfrom
Open
Update baseline profile with DeckPicker onResume journey#8Galal-20 wants to merge 1 commit intocriticalAY:baseline-profilesfrom
Galal-20 wants to merge 1 commit intocriticalAY:baseline-profilesfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Add a baseline profile test to ensure that
DeckPicker.onResume()is executed and captured during profile generation.Fixes
DeckPicker:onResumeis called ankidroid/Anki-Android#20734Approach
Added a new test
confirmOnResumeIsCalledThe test performs:
DeckPickertoPreferencesActivityvia the navigation drawerDeckPickerusing back navigationThis guarantees that
DeckPicker.onResume()is triggered during the baseline profile collectionVerified that the method is included in the generated baseline profile: SPLcom/ichi2/anki/DeckPicker;->onResume()V
How Has This Been Tested?
Steps:
Result:
DeckPicker.onResume()is present in the baseline profile:SPLcom/ichi2/anki/DeckPicker;->onResume()VTest Environment:
Checklist
Please, go through these checks before submitting the PR.