Merged
Conversation
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a fromModel helper to reduce boilerplate when converting Kubernetes model objects (e.g., kubernetes-models) into Resource protobuf wrappers.
Changes:
- Introduces
fromModel()helper that accepts either a model withtoJSON()or a plain object and returns aResource. - Adds Vitest coverage for
fromModel, plus existingfromObject/toObjectbehaviors. - Updates public exports and README usage example to recommend
fromModel.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/resource/resource.ts | Adds fromModel helper and reformats a few existing utilities |
| src/resource/resource.test.ts | Adds unit tests for fromModel, fromObject, and toObject |
| src/index.ts | Re-exports fromModel from the package entrypoint |
| README.md | Documents the simplified usage via fromModel |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Steven Borrelli <steve@borrelli.org>
Signed-off-by: Steven Borrelli <steve@borrelli.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add a
fromModelhelper to clean up the fromJson/toJson pattern that emerges from using models:Before:
after:
Fixes #
I have: