crd: remove field transformation struct and its usages#46
crd: remove field transformation struct and its usages#46muvaf merged 4 commits intocrossplane:mainfrom muvaf:field-trans
Conversation
|
@sergenyalcin thanks! I think it's not a risky change but there are conflicts with other example gen PR so I'll wait that before merging. #48 is the blocking PR actually. |
@muvaf Got it! I realized that the PR was separated after I started the review :) I will also review the blocking PR. #48 |
…commonly by different generators Signed-off-by: Muvaffak Onus <me@muvaf.com>
…between crd generator and example generator Signed-off-by: Muvaffak Onus <me@muvaf.com>
…ocessing Signed-off-by: Muvaffak Onus <me@muvaf.com>
…case where there is no schema in given path Signed-off-by: Muvaffak Onus <me@muvaf.com>
sergenyalcin
left a comment
There was a problem hiding this comment.
Thanks @muvaf I did a code review and as far as I understand the most important file is example.go In another files, mainly, changes are related the changed function call. This PR looks good to me generally.
As I said that before, these changes are related with your before works together with Alper. So apart from high-level architectural part, I focused on the code review.
Description of your changes
FieldTransformationis the one and only struct passed as result from one generator to the other. As mentioned in #9 and #4 (review) , the information it conveys is already available. So, this PR removes it and gathers that information fromconfig.Resource, using it as the source of truth for such info like all other mechanisms.Fixes #9
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Only the following diff is reported in the examples in

mainofprovider-aws: