feat: Add support for User Report Settings Templates endpoints #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add addToTm parameter support for Upload Translation API (crowdin#185)
Merge #2 feat(api): Add croql parameter support to List Terms API
- Implement UserReportSettingsTemplatesResource class - Add support for List/Add/Get/Edit/Delete User Report Settings Templates - Add comprehensive test coverage for new endpoints - Maintain existing code style and conventions Resolves crowdin#192
imprvhub
changed the title
Resolved whitespace and newline inconsistencies to ensure adherence to flake8 coding standards. These corrections improve code maintainability and align with best practices for Python formatting.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
==========================================
+ Coverage 99.36% 99.37% +0.01%
==========================================
Files 169 169
Lines 7012 7069 +57
Branches 158 159 +1
==========================================
+ Hits 6967 7024 +57
Misses 30 30
Partials 15 15 ☔ View full report in Codecov by Sentry. |
andrii-bodnar
approved these changes
Jan 30, 2025
Member
andrii-bodnar
left a comment
andrii-bodnar
left a comment
There was a problem hiding this comment.
@imprvhub thank you for the contribution!
andrii-bodnar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implemented User Report Settings Templates endpoints to complete API client's reporting capabilities (#192). This adds the missing piece for managing custom report configurations at the user level.
Implementation
UserReportSettingsTemplatesResourceclass supporting:Technical Notes
Validation
Implementation validated against official Crowdin API documentation.
Closes #192