docs(compose): refactor smoketest for generation of compose.yml, document usage #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
andrewazores
added
test
and removed
needs-triage
andrewazores
force-pushed
the
readme-compose
branch
from
b2ebecc to
bb84578
Compare
andrewazores
changed the title
andrewazores
changed the title
andrewazores
force-pushed
the
readme-compose
branch
from
7c09c0f to
d356013
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes cryostatio/cryostat-legacy#750
See also https://github.com/cryostatio/cryostat/wiki/Deploying-Cryostat-in-Docker-Podman-Compose
Description of the change:
Refactors
smoketest.bashso that the external volumes are handled cleanly during dry-runs. Using the script in dry-run mode is mostly intended for the use case now documented in the README - this was always the goal, but the volume handling prior to this PR always made it cumbersome to actually use.How to manually test: