perf(rules): use worker pool to perform Rule execution #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
changed the title
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
andrewazores
force-pushed
the
rule-execute-worker
branch
from
d43ab16 to
7e319c2
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
andrewazores
force-pushed
the
rule-execute-worker
branch
from
7e319c2 to
be0abe4
Compare
andrewazores
force-pushed
the
rule-execute-worker
branch
from
be0abe4 to
2cdd8f4
Compare
Member
Author
|
/build_test |
|
Workflow started at 11/28/2025, 10:29:47 AM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ |
7 tasks
Josh-Matsuoka
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #1154
Description of the change:
Use single threaded "activator" executor in RuleService to handle startup job of activating Rules against Targets, and then to process dispatch of ActivationAttempt queue. Activator only takes elements from queue and then fires an actual execution job to be processed on a "worker" pool, which uses virtual threads, rather than directly handling processing itself.
Motivation for the change:
Allows concurrent/parallel activation of Rules against targets. Prior to this change Rule activation would only happen serially, so if there are many discovered targets and if connections to each target are a bit slow, then Rule overall activation could take significant time. Importantly, if a discovered target is not connectable at all and would produce a connection timeout, performing these activations concurrently on different virtual threads rather than serially on a single thread allows the possible activations to take place without needing to wait for the impossible activations to time out.
How to manually test:
./smoketest.bash -O -t quarkus-cryostat-agent,vertx-fib-demo