Merged
Conversation
JoeGruffins
approved these changes
Mar 13, 2025
Collaborator
JoeGruffins
left a comment
JoeGruffins
left a comment
There was a problem hiding this comment.
Change looks fine. But when I try to build will see this, on master too:
$ go build
# gioui.org/cpu
../../go/pkg/mod/gioui.org/cpu@v0.0.0-20210817075930-8d6a761490d2/driver.go:38:10: cannot define new methods on non-local type BufferDescriptor
../../go/pkg/mod/gioui.org/cpu@v0.0.0-20210817075930-8d6a761490d2/driver.go:42:10: cannot define new methods on non-local type BufferDescriptor
../../go/pkg/mod/gioui.org/cpu@v0.0.0-20210817075930-8d6a761490d2/driver.go:53:10: cannot define new methods on non-local type ImageDescriptor
../../go/pkg/mod/gioui.org/cpu@v0.0.0-20210817075930-8d6a761490d2/driver.go:57:10: cannot define new methods on non-local type ImageDescriptor
../../go/pkg/mod/gioui.org/cpu@v0.0.0-20210817075930-8d6a761490d2/driver.go:68:10: cannot define new methods on non-local type DispatchContext
../../go/pkg/mod/gioui.org/cpu@v0.0.0-20210817075930-8d6a761490d2/driver.go:72:10: cannot define new methods on non-local type DispatchContext
../../go/pkg/mod/gioui.org/cpu@v0.0.0-20210817075930-8d6a761490d2/driver.go:76:10: cannot define new methods on non-local type DispatchContext
../../go/pkg/mod/gioui.org/cpu@v0.0.0-20210817075930-8d6a761490d2/driver.go:84:10: cannot define new methods on non-local type ThreadContext
# gioui.org/internal/vk
../../go/pkg/mod/gioui.org@v0.7.0/internal/vk/vulkan.go:1896:9: cannot define new methods on non-local type PushConstantRange
../../go/pkg/mod/gioui.org@v0.7.0/internal/vk/vulkan.go:1900:9: cannot define new methods on non-local type PushConstantRange
../../go/pkg/mod/gioui.org@v0.7.0/internal/vk/vulkan.go:1904:9: cannot define new methods on non-local type PushConstantRange
../../go/pkg/mod/gioui.org@v0.7.0/internal/vk/vulkan.go:1908:9: cannot define new methods on non-local type QueueFamilyProperties
../../go/pkg/mod/gioui.org@v0.7.0/internal/vk/vulkan.go:1912:9: cannot define new methods on non-local type SurfaceCapabilities
../../go/pkg/mod/gioui.org@v0.7.0/internal/vk/vulkan.go:1916:9: cannot define new methods on non-local type SurfaceCapabilities
Member
Author
|
@JoeGruffins what platform did you build on? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #641