Conversation
✅ Deploy Preview for specter-diy-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k9ert
force-pushed
the
kn/nix_fix
branch
2 times, most recently
from
76a401b to
e1f8a8e
Compare
|
Really nice ! tried from the kn/nix_fix Branch. works well !! I tested the simulator only for now. The reproducible builds can also benefit from flake with pined dependencies to replace the docker with debian image. |
ubbabeck
left a comment
ubbabeck
left a comment
There was a problem hiding this comment.
I left a review regarding the nix flake and shell.nix. I can help with the shell.nix if you wish.
There was a problem hiding this comment.
I think shell.nix can use the flake.nix instead of defining the dependencies twice, if you wish to support the nix-shell command.
ubbabeck
left a comment
ubbabeck
left a comment
There was a problem hiding this comment.
Added how to not having to define the dependencies twice.
Co-authored-by: Ruben <36157890+ubbabeck@users.noreply.github.com>
Co-authored-by: Ruben <36157890+ubbabeck@users.noreply.github.com>
|
Thanks Mike! At least we've tested the github workflow with this as well. I also tested locally make unix and disco. Works now! |
miketlk
left a comment
miketlk
left a comment
There was a problem hiding this comment.
Haven't tested but looks good to me.
* fix: pin dependencies via on nix and create flake * ci: try build * Update flake.nix Co-authored-by: Ruben <36157890+ubbabeck@users.noreply.github.com> * Update shell.nix Co-authored-by: Ruben <36157890+ubbabeck@users.noreply.github.com> * fix: as suggested by mike * a bit more concrete prerequisites * nix prefixes --------- Co-authored-by: Ruben <36157890+ubbabeck@users.noreply.github.com>
5 participants
fixes #295 and #296
flake.nixand updatedshell.nix. Both now usenixpkgs22.05which effectively pins the dependencies, especiallygcc-arm-embedded-9which is even no longer available on a recentnixpkgsdevelopment.mdandbuild.mdunixanddiscotarget after installing the dependencies via the flake. The binaries are uploaded and are available 90 days. The workflow kicks in for PRs to main/master and merges to main/master.We're not using the newest dependencies from nix here, as on the main branch, we're currently dependent on the gcc-arm-embedded-9 which is no longer available in 25.05.
We're pretty behind! However, Mike is currently bringing all the dependencies up to date in
#304 and there we'll pin to the latest version.